chore: support configuring pmtiles.{skip_credentials,force_path_style}

[CommanderStorm]

this PR is the followup talked about in #1477

[Copilot]

Pull Request Overview

This PR implements configuration options for S3 sources by supporting the "no_credentials" and "force_path_style" parameters, as discussed in #1477. It adds these options to the PMTiles configuration, updates the S3 source initialization logic accordingly, and revises documentation and CLI configurations.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
martin/src/pmtiles/mod.rs	Adds new configuration fields and updates the S3 source initialization logic to use them.
martin/src/args/root.rs	Refactors URL parsing using new Rust syntax for cleaner error handling.
docs/src/sources-files.md	Updates documentation regarding S3 configuration options and URL styles.
docs/src/env-vars.md	Revises environment variables documentation to include the new options.
docs/src/config-file.md	Adds configuration examples for force_path_style and no_credentials.
Cargo.toml	Updates clap dependency with the "env" feature to support new configuration options.

[CommanderStorm]

main question is likely for this PR if these env vars are fine.

[nyurik]

i think these AWS env vars are pretty standard, and I think they are ok to use.

[nyurik]

P.S. Let's document these the same way as PG env vars, together with the corresponding config keys. See above.

[CommanderStorm]

together with the corresponding config keys

They currently don't have config associated with them.
Should they be added under an pmtiles.aws.* or plmtiles.aws_*?

[nyurik]

thx, looks good, just a few minor nits

[nyurik]

i think these AWS env vars are pretty standard, and I think they are ok to use.

[nyurik]

I'm also not thrilled about the name because ideally we want all bool env parameters to be false by default, and 1 would enable them... perhaps allows_anon, skip_auth, ...?

[CommanderStorm]

I think skip_credentials does convey what we do.
We skip loading credentials.

I ommitted loading because then we would need to explain with a half sentence that we are loading them into the aws sdk.

[CommanderStorm]

Since this is the only thing blocking 0.17 and if we get this in today, we can get into the newsletter for this, rather than next month

• Call for Submissions: May 2025 Newsletter maplibre.github.io#420

Could we gain concensus, that pmtiles.skip_credentials is fine? 👉🏻👈🏻
@nyurik @sharkAndshark

(if there are things which are opposing a merge+release, that is fine too. skipping an newsletter if we did not have content is fine ^^)

[nyurik]

Sounds good, approved!