Skip to content

Use free runners Node.js CI #3715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2025
Merged

Use free runners Node.js CI #3715

merged 2 commits into from
Aug 18, 2025

Conversation

louwers
Copy link
Member

@louwers louwers commented Aug 12, 2025

Context: these cost about $200 per month and they are not needed (anymore).

@acalcutt
Copy link
Collaborator

acalcutt commented Aug 12, 2025

Seems like jwlawson/actions-setup-cmake isn't working on arm linux yet jwlawson/actions-setup-cmake#79

I have been using macos-13 on my test branch for macos-arm, so I think that shoud be fine. we moved away from it because it seemed at the time macos-14 fixed the freezing issue, but we later found that it didn't actually do that and that should actually be fixed now.

@louwers louwers requested review from cgalvan, acalcutt and HarelM August 18, 2025 18:58
@louwers louwers added the github_actions Pull requests that update GitHub Actions code label Aug 18, 2025
@acalcutt
Copy link
Collaborator

Seems fine to me, the only thing I might try is removing 'jwlawson/actions-setup-cmake' all together and see if the built in cmake works now on the other workflows. we had only added that because there was a cmake release that was giving us issues, but if the arm ubuntu workflow works without it maybe it is no longer needed at all.

@louwers
Copy link
Member Author

louwers commented Aug 18, 2025

@acalcutt The GitHub runners come with pretty recent versions of CMake pre-installed.

@louwers louwers merged commit 898c237 into maplibre:main Aug 18, 2025
43 of 44 checks passed
@acalcutt
Copy link
Collaborator

acalcutt commented Aug 18, 2025

@acalcutt The GitHub runners come with pretty recent versions of CMake pre-installed.

the issue before was the newest version was not working at one point, and we added that action in to downgrade cmake as a workaround. but it seems like that might not be needed anymore if the latest cmake is working in the arm linux runner. we can change that later though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants