-
-
Notifications
You must be signed in to change notification settings - Fork 407
Cancel pending style request when loading style JSON #3709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good.
Using the destructor to potentially do network stuff makes me nervous, but that's another matter.
Co-authored-by: Tim Sylvester <[email protected]>
@TimSylvester Nice. That destructor deletes the |
#3240 added a new method to load a style JSON from string. However when a map is loading a style asynchronously, this can lead to a race condition where the style set from JSON is overwritten by the incoming style response.
Includes a regression test.
Closes #3708