Benchmark cpu/memory usage #3697
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bloaty Results (iOS) 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3697-compared-to-main.txt |
louwers
reviewed
Aug 11, 2025
| @@ -88,6 +89,7 @@ suspend fun MapView.setStyleSuspend(styleUrl: String): Unit = | |||
| */ | |||
| class BenchmarkActivity : AppCompatActivity() { | |||
| private val TAG = "BenchmarkActivity" | |||
| private val useAdvancedMetrics = false | |||
There was a problem hiding this comment.
Is there any downside to enabling it by default?
There was a problem hiding this comment.
I was getting some error logs when calling Debug.getMemoryInfo that caused the fps to take a hit. I'm not sure if it's throttling the access, but it wasn't consistent on all test devices/emulators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few extra metrics to the benchmarking runs