Skip to content

Conversation

MikeCoats
Copy link
Contributor

@MikeCoats MikeCoats commented Aug 12, 2025

Checklist

🚨 Please review the guidelines for contributing to this repository. 🚨

  • Make sure you are making a pull request against our main branch (left side)
  • Check that that your branch is up to date with our main.
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Check that the tests and code linter both pass.
  • If you're a new contributor, please sign our contributor license agreement.

Summary

This adds three new licenses. It includes the CERN Open Hardware Licence Version 2 - Permissive, Strongly Reciprocal and Weakly Reciprocal variants, known by the CERN-OHL-P-2.0, CERN-OHL-S-2.0 and CERN-OHL-W-2.0 SPDX identifiers respectively.

Linked issues

I copied the approach taken in #4389. Let me know if you've another preferred way you'd like to handle this instead.

Description of changes

  • Adds three licenses to the ModelsHelper > license_select_options method.
  • Adds three "translations" to the English locale.
  • Adds a test to ensure one of our new options is visible in the licence drop down.
image

Much like the PR in manyfold3d#4389, this adds three new licenses. It includes
the CERN Open Hardware Licence Version 2 - Permissive, Strongly
Reciprocal and Weakly Reciprocal variants, known by the CERN-OHL-P-2.0,
CERN-OHL-S-2.0 and CERN-OHL-W-2.0 SPDX identifiers respectively.
@Floppy
Copy link
Collaborator

Floppy commented Aug 13, 2025

Thanks!

@Floppy Floppy added the feature User-facing features and product enhancements label Aug 13, 2025
@MikeCoats
Copy link
Contributor Author

I've had a look at the failing check, @Floppy, but I'm not sure it's something I can fix?

It looks like it's failing to upload the code coverage stats because I'm missing the project token. I assume this is because the token's a Github Secret, so it isn't shared with external forks.

https://github.com/manyfold3d/manyfold/actions/runs/16921248778/workflow?pr=4633#L31

Let me know if there's something you need me to do to free it up from my side.

@Floppy
Copy link
Collaborator

Floppy commented Aug 13, 2025

Ah, no worries, that's normal for builds from forks (though I do need to fix it). The tests are passing, so I'll merge manually. Thanks!

@Floppy Floppy disabled auto-merge August 13, 2025 10:56
@Floppy Floppy merged commit 1675e40 into manyfold3d:main Aug 13, 2025
11 of 12 checks passed
@github-project-automation github-project-automation bot moved this from Maybe to Done in Manyfold Roadmap Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature User-facing features and product enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants