Skip to content

[console] 优化插件 classpath 策略 #2666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 21, 2023
Merged

[console] 优化插件 classpath 策略 #2666

merged 6 commits into from
May 21, 2023

Conversation

Karlatemp
Copy link
Member

  • 添加选项以允许插件不搜索其他插件的 classpath
  • 添加选项以允许插件阻止其他未依赖此插件的插件进行引用
  • META-INF/mirai-console-plugin/options.properties

@Karlatemp Karlatemp added t:enhancement 类型: 现有功能上的优化 t:feature 类型: 新特性 s:console 子系统: mirai-console labels May 12, 2023
@cssxsh
Copy link
Contributor

cssxsh commented May 12, 2023

话说能不能顺便优化一下 JDBC 数据库驱动 的加载
JDBC 的机制貌似会把 Driver Class 存放到 Manager 里
现在的插件隔离机制貌似会让 Driver CLass 加载异常，从而找不到需要的 Driver

@cssxsh

This comment was marked as resolved.

Sign in to view
@Karlatemp Karlatemp added this to the 2.15.0-RC milestone May 12, 2023
@Karlatemp Karlatemp requested a review from Him188 May 12, 2023 14:27
Him188
Him188 reviewed May 13, 2023
View reviewed changes
@Him188
Copy link
Member

Him188 commented May 14, 2023

这属性要怎么改？

@Karlatemp
Copy link
Member Author

option.properties 或者直接用 setter

@Karlatemp Karlatemp added z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 and removed z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 labels May 14, 2023
@Him188
Copy link
Member

Him188 commented May 14, 2023

setter需要插件已经加载后才能使用，是不是已经晚了？

@Karlatemp
Copy link
Member Author

所以我提供了 META-INF/mirai-console-plugin/options.properties 初始化的时候直接设置

setter 只是保持一致性以及自由性

@Him188
Copy link
Member

Him188 commented May 14, 2023

缺少文档

@Him188 Him188 added the z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 label May 20, 2023
@Him188
Copy link
Member

Him188 commented May 20, 2023

@Karlatemp 你来合并

@Karlatemp Karlatemp merged commit 8b4af6d into dev May 21, 2023
@Karlatemp Karlatemp deleted the console/classpath-resolving branch May 21, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Him188 Him188 Him188 approved these changes

Assignees
No one assigned
Labels
s:console 子系统: mirai-console t:enhancement 类型: 现有功能上的优化 t:feature 类型: 新特性 z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排
Projects
None yet
Milestone
2.15.0-RC
Development

Successfully merging this pull request may close these issues.
3 participants
@Karlatemp @cssxsh @Him188