Skip to content

adp/stella8085.cpp: add 11 nonworking romsets #13529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025

Conversation

stonedDiscord
Copy link
Contributor

@stonedDiscord stonedDiscord commented Mar 29, 2025

New systems marked not working

Disc 2000 [stonedDiscord]
Disc 2001 [stonedDiscord]
Disc 3000 [stonedDiscord]
Doppelpot [stonedDiscord]
Elite Disc [stonedDiscord]
Extrablatt [stonedDiscord]
Excellent [stonedDiscord]
Glücks-Stern [stonedDiscord]
Juwel [stonedDiscord]
Karo As [stonedDiscord]
Kniffi [stonedDiscord]

@stonedDiscord stonedDiscord changed the title stella8085: add 11 nonworking software items adp/stella8085.cpp: add 11 nonworking romsets Apr 1, 2025
@stonedDiscord stonedDiscord force-pushed the disc2000 branch 5 times, most recently from 74f1482 to edd2437 Compare April 5, 2025 15:50
@Osso13
Copy link
Member

Osso13 commented Apr 7, 2025

rn_image_picker_lib_temp_9b7425ad-d42a-4fa5-a4c5-59b2af6e062e
PCB pic for the set for which I created the skeleton clearly shows the RTC. The XTAL was verified 10.240, so please don't remove those things. If you are sure the other sets don't have the RTC and have the different XTAL value, please create a different machine config. If the sets are actually on a significantly different kind of PCB, please create a different driver.

@stonedDiscord
Copy link
Contributor Author

stonedDiscord commented Apr 7, 2025

Those are the same PCBs, you can have a look at the board view in your browser
https://kicanvas.org/?github=https%3A%2F%2Fgithub.com%2FstonedDiscord%2Fweisse_cpu
What board revision is this, it's unreadable in the picture
image
How did you verify the crystal, it looks bent the wrong way in the picture.
The frequency is marked as 6.144MHz on the 4087-000-101 I have.

I will add a machine config in this case, the RTCs seem different enough.
4109 seems to have the same RTC

@stonedDiscord stonedDiscord marked this pull request as draft April 7, 2025 13:31
@Osso13
Copy link
Member

Osso13 commented Apr 7, 2025

the XTAL value was checked by the dumper

@Hammy1986
Copy link

Here's some pics of dice master... Thanks to @ Trol

rn_image_picker_lib_temp_172a57b
rn_image_picker_lib_temp_5fae369
rn_image_picker_lib_temp_4055ed9

@stonedDiscord
Copy link
Contributor Author

IMG_20250407_165815_831.jpg

This is why I assumed the crystal to be 6MHz.

IMG_20250407_195541_435.jpg

These are some of the most common game machines in Germany around 1990.

@stonedDiscord stonedDiscord marked this pull request as ready for review April 27, 2025 13:21
@galibert galibert merged commit d7c5398 into mamedev:master May 10, 2025
@ajrhacker
Copy link
Contributor

All program ROMs for excellent appear to be dumped at half their proper size.

@stonedDiscord
Copy link
Contributor Author

image

HN462732 is ...... 4kb each.
Sadly I don't have access to that board anymore, I'll try to get a redump.

@ajrhacker
Copy link
Contributor

ajrhacker commented May 12, 2025

The ROMs as received were 2,048 bytes each. A mistake has occurred somewhere.

If the original dumps were 4,096 bytes each, resubmitting those is all that should be necessary.

@stonedDiscord stonedDiscord deleted the disc2000 branch May 19, 2025 13:50
@cuavas
Copy link
Member

cuavas commented Jun 28, 2025

This also doesn’t have credits for additions. I’m running out of time in the month very fast. I’m just going to comment out things that don’t line up.

@cuavas
Copy link
Member

cuavas commented Jun 28, 2025

Also, are you using parent/clone relationships correctly? Are these actually different versions of the same games, or, as the comment suggests, are you making all the games on similar boards clones?

@stonedDiscord
Copy link
Contributor Author

stonedDiscord commented Jun 29, 2025

They are all different games on the same boards. Is this not how the parent/clone relation works?
The wiki says
Note that parent/clone relationships mainly exist to group different versions of the same system and are somewhat arbitrary.
In the end all of these are gambling machines that mainly change in name and decoration.
As for the credits, I dumped these myself.

@rb6502
Copy link
Contributor

rb6502 commented Jun 29, 2025

Parent/clone is for different revisions of the same game that share ROM data. Games that are different games and only share a boot ROM or something should not be clones.

@stonedDiscord
Copy link
Contributor Author

in that case they are all parents. my mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants