Skip to content

Conversation

@jjerphan
Copy link
Member

Description

Auto-update pre-commit setup after errors observed in #4016.

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

Checklist

  • My code follows the general style and conventions of the codebase, ensuring consistency
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run pre-commit run --all locally in the source folder and confirmed that there are no linter errors.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Signed-off-by: Julien Jerphanion <[email protected]>
@github-actions github-actions bot added the release::maintenance For PRs related to maintenance label Oct 13, 2025
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan marked this pull request as ready for review October 13, 2025 14:25
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 40.74844% with 285 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.88%. Comparing base (899af78) to head (37eb6a2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
libmambapy/bindings/legacy.cpp 0.00% 45 Missing ⚠️
libmamba/src/api/install.cpp 3.44% 28 Missing ⚠️
libmamba/src/core/transaction.cpp 0.00% 21 Missing ⚠️
libmamba/src/core/env_lockfile.cpp 40.00% 18 Missing ⚠️
libmamba/src/api/update.cpp 0.00% 15 Missing ⚠️
libmambapy/bindings/solver.cpp 0.00% 14 Missing ⚠️
libmamba/src/util/os_win.cpp 23.07% 10 Missing ⚠️
libmamba/src/specs/version_spec.cpp 43.75% 9 Missing ⚠️
micromamba/src/shell.cpp 0.00% 8 Missing ⚠️
libmamba/src/api/utils.cpp 0.00% 7 Missing ⚠️
... and 30 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4079      +/-   ##
==========================================
- Coverage   64.94%   64.88%   -0.07%     
==========================================
  Files         303      303              
  Lines       38906    38975      +69     
  Branches     2877     2876       -1     
==========================================
+ Hits        25269    25290      +21     
- Misses      13570    13618      +48     
  Partials       67       67              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Klaim Klaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as it still builds 👍🏽

@jjerphan jjerphan merged commit 56a818b into mamba-org:main Oct 13, 2025
35 of 37 checks passed
@jjerphan jjerphan deleted the update-pre-commit branch October 13, 2025 18:56
@JohanMabille
Copy link
Member

Life is all the pain we endeavor

@jjerphan
Copy link
Member Author

🥖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::maintenance For PRs related to maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants