-
Notifications
You must be signed in to change notification settings - Fork 419
fix CI issues related to moving dependencies #4023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d as it's used by libarchive
| "BUILD_MICROMAMBA": "ON", | ||
| "BUILD_STATIC": "ON" | ||
| "BUILD_STATIC": "ON", | ||
| "ENABLE_WIN32_XMLLITE": "ON" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need it in the preset if it is always set in the CMakeLists.txt file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI was passing withtout that change, I didnt try it yet after removing the explicit link to xmllite.lib which I find weird. It makes sense as a system-provided library, but libarchive already has it's own way of using it (see there) but enabling it in our mamba cmake file is not enough to make this work apparently.
Not sure what's best.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some clarification of the context, with a TODO note.
This reverts commit ec62904.
Description
API changes in pybind11 v3.0.0 breaks the CI. We didnt plan that change so we restrict mamba's build to use the previous versions.
Type of Change
Checklist
pre-commit run --alllocally in the source folder and confirmed that there are no linter errors.