Skip to content

Conversation

@Klaim
Copy link
Member

@Klaim Klaim commented Jul 23, 2025

Description

API changes in pybind11 v3.0.0 breaks the CI. We didnt plan that change so we restrict mamba's build to use the previous versions.

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

Checklist

  • My code follows the general style and conventions of the codebase, ensuring consistency
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run pre-commit run --all locally in the source folder and confirmed that there are no linter errors.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@github-actions github-actions bot added the release::maintenance For PRs related to maintenance label Jul 23, 2025
@Klaim Klaim changed the title restrict pybind11 to versions < 3.0.0 fix CI issues related to moving dependencies Jul 23, 2025
@github-actions github-actions bot added the release::bug_fixes For PRs fixing bugs label Jul 23, 2025
@Klaim Klaim removed the release::bug_fixes For PRs fixing bugs label Jul 24, 2025
"BUILD_MICROMAMBA": "ON",
"BUILD_STATIC": "ON"
"BUILD_STATIC": "ON",
"ENABLE_WIN32_XMLLITE": "ON"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need it in the preset if it is always set in the CMakeLists.txt file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI was passing withtout that change, I didnt try it yet after removing the explicit link to xmllite.lib which I find weird. It makes sense as a system-provided library, but libarchive already has it's own way of using it (see there) but enabling it in our mamba cmake file is not enough to make this work apparently.
Not sure what's best.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some clarification of the context, with a TODO note.

@Klaim Klaim merged commit ec62904 into mamba-org:main Jul 28, 2025
34 of 35 checks passed
@jjerphan jjerphan deleted the dependencies-pybind11-under3 branch July 29, 2025 08:19
Klaim added a commit to Klaim/mamba that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::maintenance For PRs related to maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants