Skip to content

Conversation

@jjerphan
Copy link
Member

Description

As a way to test:

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

Checklist

  • My code follows the general style and conventions of the codebase, ensuring consistency
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run pre-commit run --all locally in the source folder and confirmed that there are no linter errors.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Signed-off-by: Julien Jerphanion <[email protected]>
@github-actions github-actions bot added the release::maintenance For PRs related to maintenance label Jun 11, 2025
@jjerphan jjerphan added release::maintenance For PRs related to maintenance and removed release::maintenance For PRs related to maintenance labels Jun 11, 2025
@jjerphan jjerphan changed the title Use LGPL builds of libarchive 3.8 Use LGPL builds of libarchive>=3.8 Jun 11, 2025
@codecov
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.58%. Comparing base (f771e52) to head (bff3a99).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3982   +/-   ##
=======================================
  Coverage   63.58%   63.58%           
=======================================
  Files         300      300           
  Lines       38200    38200           
  Branches     2853     2852    -1     
=======================================
+ Hits        24288    24289    +1     
+ Misses      13845    13844    -1     
  Partials       67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jjerphan
Copy link
Member Author

I am unsure about merging this PR, but if all the tests here pass, we can merge the ones on the feedstock.

What do you think?

@JohanMabille
Copy link
Member

We should merge it to keep the feedstock and the dev environments consistent.

@jjerphan jjerphan marked this pull request as ready for review June 11, 2025 09:44
@jjerphan jjerphan changed the title Use LGPL builds of libarchive>=3.8 Depend on LGPL builds of libarchive>=3.8 Jun 11, 2025
@jjerphan jjerphan merged commit e6a391b into mamba-org:main Jun 11, 2025
40 of 43 checks passed
@jjerphan jjerphan deleted the libarchive-3.8 branch June 11, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::maintenance For PRs related to maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants