Skip to content

Conversation

@JohanMabille
Copy link
Member

Low level refactoring to reduce dependency on Context. The utilmate goal is to remove the Context from the Transaction class so that we can refactor its API and expose it more easily.

@JohanMabille JohanMabille added the release::maintenance For PRs related to maintenance label May 20, 2025
@JohanMabille JohanMabille force-pushed the transaction branch 4 times, most recently from dce209f to ca19f59 Compare May 20, 2025 15:05
@JohanMabille JohanMabille marked this pull request as draft May 20, 2025 15:05
@JohanMabille JohanMabille marked this pull request as ready for review May 20, 2025 15:13
@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 27.77778% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@b0da273). Learn more about missing BASE report.

Files with missing lines Patch % Lines
libmambapy/src/libmambapy/bindings/legacy.cpp 0.00% 4 Missing ⚠️
libmamba/src/core/shell_init.cpp 0.00% 3 Missing ⚠️
libmamba/src/core/run.cpp 0.00% 2 Missing ⚠️
libmamba/src/core/transaction_context.cpp 0.00% 2 Missing ⚠️
libmamba/src/api/utils.cpp 0.00% 1 Missing ⚠️
libmamba/src/core/util.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3949   +/-   ##
=======================================
  Coverage        ?   63.78%           
=======================================
  Files           ?      304           
  Lines           ?    37966           
  Branches        ?     2833           
=======================================
  Hits            ?    24217           
  Misses          ?    13694           
  Partials        ?       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Klaim Klaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohanMabille JohanMabille merged commit 6115ac5 into mamba-org:main May 21, 2025
37 checks passed
@JohanMabille JohanMabille deleted the transaction branch May 21, 2025 11:01
SandrineP pushed a commit to SandrineP/mamba that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::maintenance For PRs related to maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants