Skip to content

Conversation

@jjerphan
Copy link
Member

As discussed in #2524.

@jjerphan jjerphan added the release::maintenance For PRs related to maintenance label May 19, 2025
@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@aaae25f). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3946   +/-   ##
=======================================
  Coverage        ?   63.66%           
=======================================
  Files           ?      303           
  Lines           ?    37968           
  Branches        ?     2828           
=======================================
  Hits            ?    24171           
  Misses          ?    13742           
  Partials        ?       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jjerphan jjerphan marked this pull request as ready for review May 19, 2025 13:15
@jjerphan
Copy link
Member Author

@ndevenish: does this look good to you?

@ndevenish
Copy link

This solves the problem, insofar as it's removing the new notice.

Eventually removing the file might be valuable in terms of simplicity, if it is truly redundant; although I suspect you would inevitably get a constant drip-feed of asking why there is a conda.sh and not a mamba.sh.

I don't know how much was deliberate done and how much came naturally out of rewriting the notice, but I feel that the WARNING: This is required for mamba to work correctly as of 2.0. part of the new warning might be valuable? It's not just a "This is missing", it's a "this is why it is now required when it wasn't before". Feels a bit more actionable?

@jjerphan
Copy link
Member Author

I feel that the WARNING: This is required for mamba to work correctly as of 2.0. part of the new warning might be valuable?

Setting MAMBA_ROOT_PREFIX would be required if the script is removed, but it won't be required anymore since the script sets it.

Would simply reverting it to using the previous script work for you?

jjerphan added 2 commits May 28, 2025 10:55
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Copy link
Member Author

I think that I misread your comment, this should be fixed now.

@JohanMabille JohanMabille merged commit 0d3758d into mamba-org:main Jun 5, 2025
55 of 63 checks passed
@jjerphan jjerphan deleted the maint/cancel-activation-script-removal branch June 5, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::maintenance For PRs related to maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants