-
Notifications
You must be signed in to change notification settings - Fork 419
maint: Cancel activation script removal #3946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maint: Cancel activation script removal #3946
Conversation
Signed-off-by: Julien Jerphanion <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3946 +/- ##
=======================================
Coverage ? 63.66%
=======================================
Files ? 303
Lines ? 37968
Branches ? 2828
=======================================
Hits ? 24171
Misses ? 13742
Partials ? 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Hind-M <[email protected]>
|
@ndevenish: does this look good to you? |
|
This solves the problem, insofar as it's removing the new notice. Eventually removing the file might be valuable in terms of simplicity, if it is truly redundant; although I suspect you would inevitably get a constant drip-feed of asking why there is a conda.sh and not a mamba.sh. I don't know how much was deliberate done and how much came naturally out of rewriting the notice, but I feel that the |
Setting Would simply reverting it to using the previous script work for you? |
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
|
I think that I misread your comment, this should be fixed now. |
As discussed in #2524.