Skip to content

Conversation

@AntoinePrv
Copy link
Member

Move some code to make fmt::formatter::parse, which will be required for C++20.

@AntoinePrv AntoinePrv added the release::maintenance For PRs related to maintenance label May 16, 2025
@AntoinePrv AntoinePrv changed the title Constexpr fmt::formatter::parse for C++20 Constexpr fmt::formatter::parse for C++20 May 16, 2025
@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 88.00000% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@cc7d2d5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
libmamba/include/mamba/specs/build_number_spec.hpp 75.00% 2 Missing ⚠️
libmamba/include/mamba/specs/version.hpp 75.00% 2 Missing ⚠️
libmamba/src/specs/version_spec.cpp 50.00% 2 Missing ⚠️
...bmamba/include/mamba/specs/chimera_string_spec.hpp 75.00% 1 Missing ⚠️
libmamba/include/mamba/specs/glob_spec.hpp 75.00% 1 Missing ⚠️
libmamba/include/mamba/specs/match_spec.hpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3942   +/-   ##
=======================================
  Coverage        ?   63.61%           
=======================================
  Files           ?      302           
  Lines           ?    37789           
  Branches        ?     2819           
=======================================
  Hits            ?    24041           
  Misses          ?    13694           
  Partials        ?       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JohanMabille JohanMabille merged commit aaae25f into mamba-org:main May 16, 2025
37 checks passed
@Hind-M Hind-M mentioned this pull request May 27, 2025
@AntoinePrv AntoinePrv deleted the prepare-c++20 branch June 2, 2025 07:14
SandrineP pushed a commit to SandrineP/mamba that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::maintenance For PRs related to maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants