Simplify SubdirData #3926
Merged
Simplify SubdirData #3926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3926 +/- ##
=======================================
Coverage ? 63.53%
=======================================
Files ? 300
Lines ? 37481
Branches ? 2783
=======================================
Hits ? 23812
Misses ? 13616
Partials ? 53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AntoinePrv
force-pushed
the
channel-loader
branch
3 times, most recently
from
8d30ced to
67e4d93
Compare
jjerphan
approved these changes
May 12, 2025
| py::arg("db") | ||
| ) | ||
| .def("loaded", &SubdirData::is_loaded) | ||
| .def("loaded", &SubdirData::valid_cache_found) |
Member
There was a problem hiding this comment.
Should this API also be deprecated in favor of valid_cache_found?
Member
Author
There was a problem hiding this comment.
No need here, since the whole class will be deprecated in favor of a new one.
AntoinePrv
commented
May 12, 2025
Co-authored-by: Julien Jerphanion <[email protected]>
AntoinePrv
force-pushed
the
channel-loader
branch
from
a0ada2b to
45bd88c
Compare
JohanMabille
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part of the
SubdirDatarefactor. Despite big changes, this PR should be rather straightforward. The logic remains unchanged, things are only moved around. Main improvements are: