-
Notifications
You must be signed in to change notification settings - Fork 419
Internally add flag for switching MatchSpec parser #3905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89e6a31 to
2d4a130
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3905 +/- ##
=======================================
Coverage ? 62.91%
=======================================
Files ? 300
Lines ? 37124
Branches ? 2780
=======================================
Hits ? 23356
Misses ? 13716
Partials ? 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ac14358 to
02f8612
Compare
29ad15d to
1e702ec
Compare
JohanMabille
approved these changes
Apr 24, 2025
jjerphan
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a lot of
MatchSpec(all from adding package dependencies) are parsed bylibsolv, due to lack of maturity (and performance?) for our implementation. To useresolvoand to get more control over the implementation of the dependencies, we need to start using our own implementation more.This PR should... change nothing, not even
libmambaABI. It introduces internal refactors required for having the option to change the parser (which will be in a follow-up PR).