Skip to content

Conversation

@AntoinePrv
Copy link
Member

@AntoinePrv AntoinePrv commented Apr 23, 2025

Currently, a lot of MatchSpec (all from adding package dependencies) are parsed by libsolv, due to lack of maturity (and performance?) for our implementation. To use resolvo and to get more control over the implementation of the dependencies, we need to start using our own implementation more.

This PR should... change nothing, not even libmamba ABI. It introduces internal refactors required for having the option to change the parser (which will be in a follow-up PR).

@AntoinePrv AntoinePrv requested a review from Copilot April 23, 2025 08:44
@AntoinePrv AntoinePrv added the release::maintenance For PRs related to maintenance label Apr 23, 2025

This comment was marked as resolved.

@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 86.81818% with 29 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@939ed2f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
libmamba/src/solver/libsolv/helpers.cpp 78.26% 20 Missing ⚠️
libmamba/ext/solv-cpp/src/dependency.cpp 57.14% 6 Missing ⚠️
libmamba/src/solver/libsolv/unsolvable.cpp 86.66% 2 Missing ⚠️
libmamba/src/specs/match_spec.cpp 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3905   +/-   ##
=======================================
  Coverage        ?   62.91%           
=======================================
  Files           ?      300           
  Lines           ?    37124           
  Branches        ?     2780           
=======================================
  Hits            ?    23356           
  Misses          ?    13716           
  Partials        ?       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AntoinePrv AntoinePrv force-pushed the solver-matchspec branch 2 times, most recently from ac14358 to 02f8612 Compare April 23, 2025 14:32
@AntoinePrv AntoinePrv changed the title Solver improvements Internally add flag for switching MatchSpec parser Apr 24, 2025
@AntoinePrv AntoinePrv marked this pull request as ready for review April 24, 2025 07:59
@AntoinePrv AntoinePrv merged commit 306e454 into mamba-org:main Apr 24, 2025
37 checks passed
@AntoinePrv AntoinePrv deleted the solver-matchspec branch April 24, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::maintenance For PRs related to maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants