feat: use umap projections for spatgeom #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maikol-solis
force-pushed
the
feat-umap
branch
from
c3b780e to
7752b49
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds an option to project high-dimensional inputs down to two dimensions using UMAP before computing spatial geometry.
- Introduces
use_umapflag and...to pass extra UMAP parameters - Implements UMAP projection when only
xis provided with >2 columns - Adds error handling for unsupported input dimensions
Comments suppressed due to low confidence (2)
R/spatgeom.R:82
- The new
use_umapand...parameters should be added to the function’s Roxygen documentation so users know how to enable UMAP and what extra arguments they can pass.
use_umap = FALSE,
R/spatgeom.R:89
- No tests currently cover the UMAP branch. Add unit tests for
use_umap = TRUEwith a matrix of >2 columns to ensure projections and downstream logic behave as expected.
if (use_umap == TRUE && ncol(x) > 2) {
| ) | ||
| } | ||
|
|
||
| spatgeom_xy( |
There was a problem hiding this comment.
The parameter domain_type is not forwarded to spatgeom_xy in the single-input branch, so the user’s chosen domain type is ignored and the default is always used. Add domain_type = domain_type to the argument list.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.