Skip to content

Conversation

@Yeom-JinHo
Copy link
Contributor

Description

This PR focuses on fixing a script recursion issue in the root package.json and ensuring consistent runtime environments across the workspace.
Because stability is the priority, this fix introduces a minor but important adjustment.

Changes

  • Script Loop Fix (major): Updated build:docs to use
    turbo run build:docs --filter=@magicui/www
    instead of recursively calling pnpm build:docs, which caused an infinite loop at the root level.
  • Script Loop Fix (major): Updated build: registry to use
    turbo run build: registry --filter=@magicui/www
    instead of recursively calling pnpm build: registry , which caused an infinite loop at the root level.
  • Engines (consistency): Added engines field to the root package.json to enforce Node >=22.14.0 and pnpm >=9, aligning with the app configuration.

Motivation

  • Prevent infinite recursion when running pnpm build:docs from the root.
  • Prevent infinite recursion when running pnpm build:registry from the root.
  • Ensure consistent Node and pnpm versions across all environments (local + CI/CD).
  • Improve maintainability by clarifying the correct workspace target for docs build.

Breaking Changes

  • None for consumers.
  • Internal change: developers must now rely on the corrected script (turbo run …) when invoking build:docs from the root.

@vercel
Copy link

vercel bot commented Sep 16, 2025

@Yeom-JinHo is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

@Yeom-JinHo
Copy link
Contributor Author

@dillionverma
Hi! Thanks for switching us over to Turbo Repo in #797

I found a few things that needed adjusting, so I’ve pushed some updates.
Would you mind taking a look?

@dillionverma
Copy link
Collaborator

ty @Yeom-JinHo

@dillionverma dillionverma merged commit 7080149 into magicuidesign:main Sep 17, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants