Skip to content

Conversation

sohebmahmood-madetech
Copy link
Contributor

So admittedly I don't really feel so good about this implementation.

I feel confident about the way I store the session data into local storage, but the way I retrieve session storage and how I add it into the store... I feel less comfortable with.

Also, this has a known issue in that restoring from local storage will definitely update the graph but it won't update the sliders on the right, and that's because it seems to be a bit of a known issue with react-likert-scale (see here)

@sohebmahmood-madetech
Copy link
Contributor Author

OK I'm much more comfortable with the solution I have now - it uses modern React effects to manage the rendering once in our functional component without much additional code.

There was a eslint warning which I intentionally disabled in SkillsSelector.js as what I'm doing is very intentionally doing the equivalent of componentDidMount and not componentDidUpdate, which needs dependencies in the array (on line 19).

@struds struds merged commit 5ebbf69 into madetech:main Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants