Allow Host to be overridden in handshake headers #530
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a situation with a thirdparty websocket server which was rejecting the upgrade to a websocket connection (in
IXWebSocketHandshake::clientHandshake(...)
) with a HTTP 400 (Bad Request) error because the thirdparty server didn't like the format of the "Host:" header being set to "stream.example.com:port", so, e.g.Failed with a HTTP 400 error code (when IXWebSocket expects a HTTP 101 Switching Protocols code), but the following without ":port":
Worked OK.
This small change allows the "Host" header to be specified in `ix::WebSocketHttpHeaders", e.g.
Will give the desired result.
Added a few test cases.