Add ping interval to constructor params for WebSocketServer #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CR passed, do you mind checking if the documentation should be updated ? (under the docs folder) ? |
|
I added a paragraph to the usage documentation. I couldn't find anywhere else relevant worth updating. Let me know if you have any other requests to move this PR forward. |
bsergean
approved these changes
Mar 12, 2024
|
Thanks ! Just merged your change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not find any way to enable the ping heartbeat for all connections while configuring the WebSocketServer class. I added the parameter pingIntervalSeconds to the constructor to allow for this to be configured at construction time. Per my reading of the code and some local sanity checking, setting this parameter for all child connections enables the heartbeat feature.
If there was a better way for me to achieve this without the modification in this PR, please let me know and we can close. Otherwise, let me know if there are any further modifications you would like before we can merge this into master.