Add comprehensive type hints and improve error handling #1212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves code quality by adding comprehensive type hints and fixing error handling issues throughout the codebase.
Changes Made
1. Type Hints Added (utils.py)
make_safe
,exact_div
,str2bool
,optional_int
,optional_float
,interpolate_nans
2. Error Handling Improvements
utils.py
exact_div
to explicitly check for division by zerooptional_int
andoptional_float
with proper exception handling and descriptive error messagesvads/pyannote.py
open(model_fp, 'rb').read()
with proper context manageralignment.py
except Exception
with specific exceptions:OSError
,RuntimeError
,KeyError
from e
for better debugging3. Documentation Improvements (SubtitlesProcessor.py)
4. Test Suite
test_improvements.py
Benefits
Testing
All tests pass successfully:
The test suite demonstrates that all changes work correctly and maintain backward compatibility.
Backward Compatibility
All changes are backward compatible - no breaking changes to existing APIs.