ci: check 3.327.1 runner for lynx-stack #1470
Conversation
|
📝 WalkthroughWalkthroughAll modified files are GitHub Actions workflow definitions. The only change across all workflows is updating the runner environment for various jobs from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (6)
.github/workflows/test.yml (6)
63-63: Same note about custom runner label and actionlint.
116-116: Same note about custom runner label and actionlint.
140-140: Same note about custom runner label and actionlint.
168-168: Same note about custom runner label and actionlint.
196-196: Same note about custom runner label and actionlint.
199-199: Same note about custom runner label and actionlint.
🧹 Nitpick comments (10)
.github/workflows/workflow-bench.yml (1)
16-16: Silence actionlint for custom self-hosted labelsactionlint warns that this label is unknown. Add/adjust actionlint config to whitelist your custom labels.
Example .actionlint.yaml:
self-hosted-runner-labels: - lynx-ubuntu-24.04-medium - lynx-ubuntu-24.04-medium-verify - lynx-ubuntu-24.04-xlarge - lynx-ubuntu-24.04-xlarge-verify - lynx-windows-2022-large.github/workflows/workflow-website.yml (1)
12-12: Confirm the custom self-hosted runner label is registered"lynx-ubuntu-24.04-medium-verify" looks fine; just ensure it’s present in your runner pool. To avoid CI noise from actionlint, add it to .actionlint.yaml’s self-hosted-runner-labels (see bench review for example).
.github/workflows/relative-ci.yml (1)
28-28: Validate runner label and whitelist in actionlintPlease confirm "lynx-ubuntu-24.04-medium-verify" exists in your self-hosted fleet and add it to actionlint’s known labels to silence the warning.
.github/workflows/workflow-build.yml (1)
12-12: Self-hosted label check + actionlint config"lynx-ubuntu-24.04-medium-verify" should be whitelisted in .actionlint.yaml and verified to exist in the runner pool.
.github/workflows/nodejs-dependencies.yml (1)
24-24: Runner label verification and lintingConfirm availability of "lynx-ubuntu-24.04-medium-verify" and add it to actionlint’s self-hosted-runner-labels list to prevent false positives.
.github/workflows/rust.yml (1)
79-79: Same note as above for custom labelEnsure the label exists on the target fleet for runner v3.327.1 and is whitelisted in actionlint.yaml to avoid linter noise.
.github/workflows/workflow-bundle-analysis.yml (1)
13-13: Custom self-hosted label — add to actionlint configAdd lynx-ubuntu-24.04-medium-verify to actionlint.yaml self-hosted labels to silence (runner-label) warnings.
.github/workflows/code-scanning.yml (2)
20-20: Whitelist custom runner label for actionlintAdd lynx-ubuntu-24.04-medium-verify to actionlint.yaml (self-hosted-runner-labels) to avoid linter warnings.
91-91: Same: whitelist label in actionlint configPrevents (runner-label) warnings for zizmor job as well.
.github/workflows/pull-request-content-check.yml (1)
17-17: Custom label — actionlint whitelistAdd lynx-ubuntu-24.04-medium-verify to actionlint.yaml’s self-hosted-runner-labels to keep CI lint green.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
.github/workflows/code-scanning.yml(2 hunks).github/workflows/deploy-main.yml(1 hunks).github/workflows/nodejs-dependencies.yml(1 hunks).github/workflows/pull-request-content-check.yml(1 hunks).github/workflows/relative-ci.yml(1 hunks).github/workflows/rust.yml(2 hunks).github/workflows/test.yml(6 hunks).github/workflows/workflow-bench.yml(1 hunks).github/workflows/workflow-build.yml(1 hunks).github/workflows/workflow-bundle-analysis.yml(1 hunks).github/workflows/workflow-website.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.627Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
📚 Learning: 2025-07-22T09:26:16.722Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.
Applied to files:
.github/workflows/workflow-bench.yml.github/workflows/code-scanning.yml.github/workflows/workflow-website.yml.github/workflows/relative-ci.yml.github/workflows/workflow-bundle-analysis.yml.github/workflows/deploy-main.yml.github/workflows/workflow-build.yml.github/workflows/nodejs-dependencies.yml.github/workflows/pull-request-content-check.yml.github/workflows/rust.yml.github/workflows/test.yml
📚 Learning: 2025-07-22T09:23:07.797Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.
Applied to files:
.github/workflows/workflow-bench.yml.github/workflows/relative-ci.yml.github/workflows/workflow-bundle-analysis.yml.github/workflows/nodejs-dependencies.yml
📚 Learning: 2025-08-07T04:00:59.627Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.627Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
Applied to files:
.github/workflows/nodejs-dependencies.yml
🪛 actionlint (1.7.7)
.github/workflows/workflow-bench.yml
16-16: label "lynx-ubuntu-24.04-medium-verify-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/code-scanning.yml
20-20: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
91-91: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/workflow-website.yml
12-12: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/relative-ci.yml
28-28: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/workflow-bundle-analysis.yml
13-13: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/workflow-build.yml
12-12: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/nodejs-dependencies.yml
24-24: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/pull-request-content-check.yml
17-17: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/rust.yml
63-63: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
79-79: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/test.yml
33-33: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
199-199: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🔇 Additional comments (4)
.github/workflows/workflow-bench.yml (1)
16-16: Fix typo in runner label & preserve benchmark hardware class consistency
- Location:
.github/workflows/workflow-bench.yml, line 16- Issue: The
runs-onlabel has a duplicated-verify, and moving fromxlarge→mediumwill change the hardware profile and skew benchmarks.You have two options:
Correct the label typo only:
- runs-on: lynx-ubuntu-24.04-medium-verify-verify + runs-on: lynx-ubuntu-24.04-medium-verify(Recommended for benchmark parity) Restore the original hardware class:
- runs-on: lynx-ubuntu-24.04-medium-verify + runs-on: lynx-ubuntu-24.04-xlarge-verifyAction: Confirm that your self-hosted runner fleet supports the chosen label before merging.
.github/workflows/test.yml (3)
33-33: Verify the new self-hosted runner label and actionlint configuration.The label "lynx-ubuntu-24.04-medium-verify" must exist on your self-hosted runner fleet. Also, actionlint flags this label as unknown; update your actionlint config to allow this custom label to keep lint green.
- Confirm the runner with this label is online and assigned to the correct runner group for this repo.
- Update actionlint configuration to whitelist this label (and any other custom labels you use).
210-214: Inconsistent Linux label in Vitest matrix — not using the new “-verify” runner.If the PR’s goal is to exercise runner 3.327.1 via “lynx-ubuntu-24.04-medium-verify”, consider updating the Ubuntu entry here as well. Today it still targets "lynx-ubuntu-24.04-medium", so those Vitest Linux runs won’t verify the new runner.
Suggested change:
- - name: Ubuntu - label: lynx-ubuntu-24.04-medium + - name: Ubuntu + label: lynx-ubuntu-24.04-medium-verify
58-65: No action needed:runs-oninput is correctly declared and used
The reusable workflow in.github/workflows/workflow-test.ymldeclares a requiredruns-oninput underworkflow_call.inputsand applies it viajobs.<id>.runs-on: ${{ inputs.runs-on }}. Everything aligns as expected.
| @@ -85,7 +85,7 @@ jobs: | |||
| secrets: | |||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} | |||
| with: | |||
| runs-on: lynx-ubuntu-24.04-medium | |||
| runs-on: lynx-ubuntu-24.04-medium-verify | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Confirm called workflow accepts and applies this runs-on input
Because this is passed to workflow-test.yml via workflow_call, verify that:
- inputs.runs-on is defined there, and
- jobs use runs-on: ${{ inputs.runs-on }}.
If not, this change won’t take effect.
You can check quickly:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Inputs definition:"
rg -n --pretty $'^\\s*inputs:\\s*[\\s\\S]*?runs-on:' .github/workflows/workflow-test.yml -A 10 || true
echo
echo "Usage in jobs:"
rg -n --pretty $'runs-on:\\s*\\$\\{\\{\\s*inputs\\.runs-on\\s*\\}\\}' .github/workflows/workflow-test.yml -A 2 || trueLength of output: 394
Define the runs-on input in your callee workflow
The caller now passes with.runs-on, but in .github/workflows/workflow-test.yml there is no inputs.runs-on defined—so the value will be ignored even though you do use runs-on: ${{ inputs.runs-on }} in the job.
Please update .github/workflows/workflow-test.yml under on.workflow_call.inputs to include:
on:
workflow_call:
inputs:
+ runs-on:
+ description: 'Runner to use for the test jobs'
+ required: true
+ # optional: default: 'ubuntu-latest'This ensures your runs-on: ${{ inputs.runs-on }} actually picks up the value passed by the caller.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| runs-on: lynx-ubuntu-24.04-medium-verify | |
| # File: .github/workflows/workflow-test.yml | |
| on: | |
| workflow_call: | |
| inputs: | |
| runs-on: | |
| description: 'Runner to use for the test jobs' | |
| required: true | |
| # optional: default: 'ubuntu-latest' | |
| # … rest of workflow-test.yml … |
🤖 Prompt for AI Agents
In .github/workflows/workflow-test.yml, add a definition for the runs-on input
under on.workflow_call.inputs to match the runs-on value passed from the caller
in .github/workflows/deploy-main.yml line 88. This will ensure that the job's
runs-on: ${{ inputs.runs-on }} correctly receives and uses the passed value
instead of ignoring it.
| @@ -60,7 +60,7 @@ jobs: | |||
| files: target/nextest/ci/test-report.junit.xml | |||
|
|
|||
| rustfmt: | |||
| runs-on: lynx-ubuntu-24.04-medium | |||
| runs-on: lynx-ubuntu-24.04-medium-verify | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Using custom self-hosted runner label — whitelist for actionlint and verify fleet availability
Looks fine for the PR goal. To avoid actionlint false positives and ensure consistency, add the label to actionlint config and run a repo-wide check for typos/outliers.
Repo-wide verification (checks for typos like “verify-verify”, and finds any lingering non-verify labels):
Optionally whitelist labels in actionlint.yaml to silence (runner-label) warnings:
+## actionlint.yaml
+self-hosted-runner-labels:
+ - lynx-ubuntu-24.04-medium-verify
+ - lynx-ubuntu-24.04-xlargeIf you want, I can extend the script to validate existence via GitHub API (gh) against your repo’s self-hosted runners.
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "1) Find suspicious labels (e.g., verify-verify):"
rg -n --pretty --context 2 $'runs-on.*verify-verify|lynx-ubuntu-[^\\s\'"]*-verify-verify' .github/workflows || true
echo
echo "2) List all custom lynx runner labels referenced:"
rg -n --pretty $'runs-on:\\s*(\\[.*\\]|[^\\n]+)' .github/workflows \
| sed -n 's/.*runs-on:\\s*\\(.*\\)$/\\1/p' \
| tr -d '[]",' | tr ' ' '\n' | sed -n 's/^\\s*\\(lynx-[^\\s]*\\)\\s*$/\\1/p' | sort -u
echo
echo "3) Find any remaining non-verify medium/xlarge labels:"
rg -n --pretty $'lynx-ubuntu-24\\.04-(medium|xlarge)(?!-verify)(?!-verify-verify)' .github/workflows || trueLength of output: 1463
Fix duplicate “-verify” suffix and whitelist valid runner labels
The new runner in rust.yml is correct, but there’s a typo in workflow-bench.yml. To prevent actionlint warnings and catch any future label mistakes:
• Correct the typo in .github/workflows/workflow-bench.yml:
--- a/.github/workflows/workflow-bench.yml
@@ -14,7 +14,7 @@
if: github.event_name != 'merge_group'
- runs-on: lynx-ubuntu-24.04-medium-verify-verify
+ runs-on: lynx-ubuntu-24.04-medium-verify• Whitelist your self-hosted labels in actionlint.yaml:
self-hosted-runner-labels:
- lynx-ubuntu-24.04-medium-verify
- lynx-ubuntu-24.04-xlarge-verify # add other sizes as needed• Run a repo-wide scan to catch any other typos:
rg --pcre2 -n 'lynx-ubuntu-24\.04-(medium|xlarge)-verify' .github/workflowsOptional: I can help you add a GitHub CLI snippet to verify these labels exist in your org’s self-hosted runner pool.
🧰 Tools
🪛 actionlint (1.7.7)
63-63: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🤖 Prompt for AI Agents
In .github/workflows/workflow-bench.yml around the line where the runner label
is set, fix the duplicate “-verify” suffix typo by ensuring the label matches
the correct format like "lynx-ubuntu-24.04-medium-verify". Then, in
actionlint.yaml, add a whitelist entry under self-hosted-runner-labels for all
valid runner labels such as "lynx-ubuntu-24.04-medium-verify" and
"lynx-ubuntu-24.04-xlarge-verify". Finally, run a repository-wide search using
the provided regex command to find and correct any other label typos in the
workflow files.
deanjingshui
force-pushed
the
p/deanjingshui/verify-327.1-stack
branch
from
2657624 to
a5c7808
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (2)
.github/workflows/rust.yml (1)
79-79: Repo-wide runner label sanity check (and bench typo)
Good here. Also confirm no stray typos like “-verify-verify” remain (one was noted in workflow-bench.yml).#!/bin/bash set -euo pipefail echo "Find suspicious labels (e.g., verify-verify):" rg -n --pretty --context 2 $'runs-on.*verify-verify|lynx-ubuntu-[^\\s\'"]*-verify-verify' .github/workflows || true echo echo "List all custom lynx runner labels referenced:" rg -n --pretty $'runs-on:\\s*(\\[.*\\]|[^\\n]+)' .github/workflows \ | sed -n 's/.*runs-on:\\s*\\(.*\\)$/\\1/p' \ | tr -d '[]",' | tr ' ' '\n' | sed -n 's/^\\s*\\(lynx-[^\\s]*\\)\\s*$/\\1/p' | sort -u.github/workflows/test.yml (1)
199-199: Typos job on verify runner — good; repo-wide scan for label issuesOK here. Run a quick repo-wide scan for “verify-verify” and list referenced custom labels.
#!/bin/bash set -euo pipefail rg -n --pretty --context 2 $'runs-on.*verify-verify|lynx-ubuntu-[^\\s\'"]*-verify-verify' .github/workflows || true rg -n --pretty $'runs-on:\\s*(\\[.*\\]|[^\\n]+)' .github/workflows \ | sed -n 's/.*runs-on:\\s*\\(.*\\)$/\\1/p' \ | tr -d '[]",' | tr ' ' '\n' | sed -n 's/^\\s*\\(lynx-[^\\s]*\\)\\s*$/\\1/p' | sort -u
🧹 Nitpick comments (13)
.github/workflows/workflow-website.yml (1)
12-12: Custom runner label needs validation and actionlint configEnsure the self-hosted label "lynx-ubuntu-24.04-medium-verify" exists in your fleet and is online. actionlint warns about unknown labels; add them to actionlint.yaml or include the generic "self-hosted" label if that’s your convention.
Example actionlint config:
runner-label: - lynx-ubuntu-24.04-medium-verifyOr adjust runs-on if you include generic labels:
runs-on: [self-hosted, linux, x64, lynx-ubuntu-24.04-medium-verify].github/workflows/workflow-build.yml (1)
12-12: Confirm availability of custom runner label and silence actionlintVerify that "lynx-ubuntu-24.04-medium-verify" exists and is assigned to the target self-hosted runners. To avoid actionlint failures, whitelist this label in your actionlint config or add the generic "self-hosted" label to the runs-on array if applicable.
Examples:
- actionlint.yaml
runner-label: - lynx-ubuntu-24.04-medium-verify
- runs-on with generic labels
runs-on: [self-hosted, linux, x64, lynx-ubuntu-24.04-medium-verify].github/workflows/relative-ci.yml (1)
28-28: Validate custom runner label for RelativeCI upload job"lynx-ubuntu-24.04-medium-verify" must be registered on your self-hosted runner(s). If actionlint runs in CI, add this label to its config or include "self-hosted" in runs-on.
Examples:
# actionlint.yaml runner-label: - lynx-ubuntu-24.04-medium-verifyruns-on: [self-hosted, linux, x64, lynx-ubuntu-24.04-medium-verify].github/workflows/nodejs-dependencies.yml (1)
24-24: Check custom runner label and update actionlint configurationEnsure "lynx-ubuntu-24.04-medium-verify" is an active label on your self-hosted runner. actionlint will flag it as unknown unless you whitelist it or include generic "self-hosted" in runs-on.
Examples:
# actionlint.yaml runner-label: - lynx-ubuntu-24.04-medium-verifyruns-on: [self-hosted, linux, x64, lynx-ubuntu-24.04-medium-verify].github/workflows/rust.yml (1)
63-63: Switch to verify runner looks good; add actionlint whitelist for custom labelLabel lynx-ubuntu-24.04-medium-verify is custom; actionlint will warn unless whitelisted. Consider adding it to actionlint.yaml.
Add/update actionlint config:
+## actionlint.yaml +self-hosted-runner-labels: + - lynx-ubuntu-24.04-medium-verify + - lynx-ubuntu-24.04-xlarge.github/workflows/workflow-bundle-analysis.yml (1)
13-13: Using lynx-ubuntu-24.04-medium-verify — remember actionlint whitelistChange aligns with PR goal. Add the custom label to actionlint.yaml to avoid (runner-label) warnings.
.github/workflows/code-scanning.yml (1)
91-91: zizmor job runner updated — add label to actionlint configConsistent with the PR. Add lynx-ubuntu-24.04-medium-verify to actionlint.yaml.
.github/workflows/pull-request-content-check.yml (1)
17-17: LGTM; actionlint config for custom labelRunner label change is fine. Add label to actionlint.yaml to silence unknown label warning.
.github/workflows/test.yml (5)
33-33: LGTM; whitelist custom label in actionlintChange is correct. Add lynx-ubuntu-24.04-medium-verify to actionlint.yaml to avoid warnings.
116-116: API checks on verify runner — goodConsistent with the migration. Also whitelist label in actionlint.yaml.
140-140: Publish flow on verify runner — goodNo issues spotted. Remember actionlint whitelist.
168-168: React tests on verify runner — goodLooks consistent. Add label to actionlint.yaml if not already.
196-196: Type tests on verify runner — goodAll set. Ensure actionlint whitelist exists.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
.github/workflows/code-scanning.yml(2 hunks).github/workflows/deploy-main.yml(1 hunks).github/workflows/nodejs-dependencies.yml(1 hunks).github/workflows/pull-request-content-check.yml(1 hunks).github/workflows/relative-ci.yml(1 hunks).github/workflows/rust.yml(2 hunks).github/workflows/test.yml(6 hunks).github/workflows/workflow-bench.yml(1 hunks).github/workflows/workflow-build.yml(1 hunks).github/workflows/workflow-bundle-analysis.yml(1 hunks).github/workflows/workflow-website.yml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/deploy-main.yml
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.627Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
📚 Learning: 2025-07-22T09:26:16.722Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.
Applied to files:
.github/workflows/code-scanning.yml.github/workflows/nodejs-dependencies.yml.github/workflows/pull-request-content-check.yml.github/workflows/relative-ci.yml.github/workflows/rust.yml.github/workflows/test.yml.github/workflows/workflow-bench.yml.github/workflows/workflow-build.yml.github/workflows/workflow-bundle-analysis.yml.github/workflows/workflow-website.yml
📚 Learning: 2025-08-07T04:00:59.627Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.627Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
Applied to files:
.github/workflows/nodejs-dependencies.yml
📚 Learning: 2025-07-22T09:23:07.797Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.
Applied to files:
.github/workflows/nodejs-dependencies.yml.github/workflows/relative-ci.yml.github/workflows/workflow-bench.yml.github/workflows/workflow-bundle-analysis.yml
📚 Learning: 2025-08-06T13:28:57.139Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.139Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/vitest.config.js` is a template file for scaffolding new Rspeedy projects, not a test configuration that should be included in the main vitest projects array.
Applied to files:
.github/workflows/relative-ci.yml
🪛 actionlint (1.7.7)
.github/workflows/code-scanning.yml
20-20: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
91-91: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/nodejs-dependencies.yml
24-24: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/pull-request-content-check.yml
17-17: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/relative-ci.yml
28-28: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/rust.yml
63-63: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
79-79: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/test.yml
33-33: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
199-199: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/workflow-bench.yml
16-16: label "lynx-ubuntu-24.04-medium-verify-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/workflow-build.yml
12-12: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/workflow-bundle-analysis.yml
13-13: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/workflow-website.yml
12-12: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🔇 Additional comments (1)
.github/workflows/test.yml (1)
211-213: Inconsistent label in vitest matrixUbuntu entry still uses lynx-ubuntu-24.04-medium (no “-verify”). If the intent is to validate the 3.327.1 verify pool everywhere, consider switching this to lynx-ubuntu-24.04-medium-verify as well.
- - name: Ubuntu - label: lynx-ubuntu-24.04-medium + - name: Ubuntu + label: lynx-ubuntu-24.04-medium-verify
| @@ -17,7 +17,7 @@ jobs: | |||
| # - https://gh.io/supported-runners-and-hardware-resources | |||
| # - https://gh.io/using-larger-runners (GitHub.com only) | |||
| # Consider using larger runners or machines with greater resources for possible analysis time improvements. | |||
| runs-on: lynx-ubuntu-24.04-medium | |||
| runs-on: lynx-ubuntu-24.04-medium-verify | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
CodeQL on verify runner — ensure pool capacity & whitelist label
Looks fine. Make sure the verify pool has enough capacity for CodeQL and whitelist the label in actionlint.yaml.
🏁 Script executed:
#!/bin/bash
# Quick check of CodeQL jobs concurrency footprint reference (counts jobs):
rg -n 'name:\\s*CodeQL Analyze' .github/workflows | wc -lLength of output: 61
🏁 Script executed:
#!/bin/bash
set -e
echo "1) Searching for job names containing 'Analyze' in workflows:"
rg -n 'name:.*Analyze' .github/workflows || echo "No matches for 'name:.*Analyze'"
echo
echo "2) Searching for CodeQL analyze action usage:"
rg -n 'uses:.*codeql-action/analyze' .github/workflows || echo "No usage of github/codeql-action/analyze"
echo
echo "3) Locating actionlint configuration files:"
find . -type f \( -iname 'actionlint*.yaml' -o -iname 'actionlint*.yml' \) -maxdepth 2 || echo "No actionlint config found"
echo
echo "4) Checking for 'lynx-ubuntu-24.04-medium-verify' in actionlint configs:"
find . -type f \( -iname 'actionlint*.yaml' -o -iname 'actionlint*.yml' \) -maxdepth 2 -print0 | xargs -0 rg -n 'lynx-ubuntu-24.04-medium-verify' || echo "Runner label not found in actionlint configs"Length of output: 1185
Whitelist the new verify runner in actionlint config & ensure CodeQL capacity
- .github/workflows/code-scanning.yml (line 20) uses
runs-on: lynx-ubuntu-24.04-medium-verify. - No actionlint configuration file found—add or update
actionlint.yaml(e.g. in the repo root or.github/) to whitelist this runner label:runners: whitelist: - lynx-ubuntu-24.04-medium-verify
- There is 1 CodeQL Analyze job in this workflow—verify your self-hosted pool can handle at least this concurrency.
🧰 Tools
🪛 actionlint (1.7.7)
20-20: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🤖 Prompt for AI Agents
In .github/workflows/code-scanning.yml at line 20, the workflow uses a custom
runner label 'lynx-ubuntu-24.04-medium-verify' which is not yet whitelisted in
the actionlint configuration. To fix this, create or update the actionlint.yaml
file (in the repo root or .github/) to include this runner label under the
whitelist section. Additionally, verify that your self-hosted CodeQL pool has
sufficient capacity to handle the concurrency of the CodeQL Analyze job in this
workflow.
| @@ -60,7 +60,7 @@ jobs: | |||
| uses: ./.github/workflows/workflow-test.yml | |||
| permissions: {} | |||
| with: | |||
| runs-on: lynx-ubuntu-24.04-medium | |||
| runs-on: lynx-ubuntu-24.04-medium-verify | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Reusable job input updated — verify called workflow honors label
Ensure workflow-test.yml uses the provided runs-on input directly.
🏁 Script executed:
#!/bin/bash
ast-grep --pattern $'name: workflow-test\njobs: $_\n test:\n runs-on: ${{ inputs.runs-on }}\n $$$'Length of output: 102
🏁 Script executed:
#!/bin/bash
# Locate workflow definition and verify runs-on usage in .github/workflows/test.yml
echo "=== Workflow name ==="
rg -n "name: workflow-test" .github/workflows/test.yml
echo
echo "=== 'runs-on' occurrences ==="
rg -n "runs-on" .github/workflows/test.yml
echo
echo "=== Reference to inputs.runs-on ==="
rg -n "inputs.runs-on" .github/workflows/test.yml || echo "No reference to inputs.runs-on found"Length of output: 1038
Update test job to use the runs-on input
The test job in .github/workflows/test.yml is still hard-coding the runner label instead of using the reusable-workflow input. Please replace the hard-coded value at line 63 with the input reference:
• File: .github/workflows/test.yml
• Line 63
- runs-on: lynx-ubuntu-24.04-medium-verify
+ runs-on: ${{ inputs.runs-on }}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| runs-on: lynx-ubuntu-24.04-medium-verify | |
| runs-on: ${{ inputs.runs-on }} |
🤖 Prompt for AI Agents
In .github/workflows/test.yml at line 63, replace the hard-coded runner label
"lynx-ubuntu-24.04-medium-verify" with the reusable-workflow input reference for
`runs-on`. This means changing the value to use the input variable that is
passed into the workflow instead of a fixed string, ensuring the job uses the
dynamic runner label provided by the input.
check the new version(3.327.1) runner for lynx-stack repo
React Example#3898 Bundle Size — 235.26KiB (0%).f8e8e7f(current) vs ed2ddcc main#3893(baseline) Bundle metrics
|
| Current #3898 |
Baseline #3893 |
|
|---|---|---|
 Initial JS |
0B |
0B |
| Initial CSS |
0B |
0B |
| Cache Invalidation |
0% |
0% |
| Chunks |
0 |
0 |
| Assets |
4 |
4 |
| Modules |
159 |
159 |
| Duplicate Modules |
64 |
64 |
| Duplicate Code |
45.81% |
45.81% |
| Packages |
2 |
2 |
| Duplicate Packages |
0 |
0 |
Bundle size by type no changes
| Current #3898 |
Baseline #3893 |
|
|---|---|---|
| IMG |
145.76KiB |
145.76KiB |
| Other |
89.5KiB |
89.5KiB |
Bundle analysis report Branch deanjingshui:p/deanjingshui/veri... Project dashboard
Generated by RelativeCI Documentation Report issue
Web Explorer#3894 Bundle Size — 342.66KiB (-0.25%).f8e8e7f(current) vs ed2ddcc main#3889(baseline) Bundle metrics
|
| Current #3894 |
Baseline #3889 |
|
|---|---|---|
 Initial JS |
142.35KiB(-0.45%) |
143KiB |
| Initial CSS |
31.84KiB |
31.84KiB |
 Cache Invalidation |
50.51% |
41.62% |
| Chunks |
7 |
7 |
| Assets |
7 |
7 |
| Modules |
212 |
212 |
| Duplicate Modules |
17 |
17 |
| Duplicate Code |
3.96%(-0.25%) |
3.97% |
| Packages |
4 |
4 |
| Duplicate Packages |
0 |
0 |
Bundle size by type 1 change 1 improvement
| Current #3894 |
Baseline #3889 |
|
|---|---|---|
| JS |
227.87KiB (-0.38%) |
228.74KiB |
| Other |
82.95KiB |
82.95KiB |
| CSS |
31.84KiB |
31.84KiB |
Bundle analysis report Branch deanjingshui:p/deanjingshui/veri... Project dashboard
Generated by RelativeCI Documentation Report issue
deanjingshui
force-pushed
the
p/deanjingshui/verify-327.1-stack
branch
from
a5c7808 to
f8e8e7f
Compare
deanjingshui
changed the title
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (7)
.github/workflows/workflow-website.yml (1)
12-12: Same “self-hosted” / actionlint issue as benchmark workflow
See fix proposed in workflow-bench.yml..github/workflows/relative-ci.yml (1)
28-28: Same “self-hosted” / actionlint issue as benchmark workflow
See fix proposed in workflow-bench.yml..github/workflows/workflow-build.yml (1)
12-12: Same “self-hosted” / actionlint issue as benchmark workflow
See fix proposed in workflow-bench.yml..github/workflows/nodejs-dependencies.yml (1)
24-24: Same “self-hosted” / actionlint issue as benchmark workflow
See fix proposed in workflow-bench.yml..github/workflows/workflow-bundle-analysis.yml (1)
13-13: Same actionlint whitelist required for this workflow
The build job now runs onlynx-ubuntu-24.04-medium-verify; make sure the label is added toactionlint.yamlas shown in the Rust workflow comment..github/workflows/code-scanning.yml (1)
20-20: Actionlint still flags the new runner label
Bothcodeqlandzizmorjobs now use the verify runner. Ensure the label is present inactionlint.yaml; otherwise CI (and pre-commit hooks) will continue to warn.Also applies to: 91-91
.github/workflows/pull-request-content-check.yml (1)
17-18: Add the PR-title lint job runner to the actionlint whitelist
lynx-ubuntu-24.04-medium-verifymust be listed inactionlint.yamlto silence the “unknown label” diagnostic.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
.github/workflows/code-scanning.yml(2 hunks).github/workflows/deploy-main.yml(1 hunks).github/workflows/nodejs-dependencies.yml(1 hunks).github/workflows/pull-request-content-check.yml(1 hunks).github/workflows/relative-ci.yml(1 hunks).github/workflows/rust.yml(2 hunks).github/workflows/test.yml(6 hunks).github/workflows/workflow-bench.yml(1 hunks).github/workflows/workflow-build.yml(1 hunks).github/workflows/workflow-bundle-analysis.yml(1 hunks).github/workflows/workflow-website.yml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/deploy-main.yml
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.627Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
📚 Learning: 2025-07-22T09:26:16.722Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.
Applied to files:
.github/workflows/code-scanning.yml.github/workflows/nodejs-dependencies.yml.github/workflows/pull-request-content-check.yml.github/workflows/relative-ci.yml.github/workflows/rust.yml.github/workflows/test.yml.github/workflows/workflow-bench.yml.github/workflows/workflow-build.yml.github/workflows/workflow-bundle-analysis.yml.github/workflows/workflow-website.yml
📚 Learning: 2025-07-22T09:23:07.797Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.
Applied to files:
.github/workflows/code-scanning.yml.github/workflows/nodejs-dependencies.yml.github/workflows/relative-ci.yml.github/workflows/test.yml.github/workflows/workflow-bundle-analysis.yml
📚 Learning: 2025-08-07T04:00:59.627Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1454
File: pnpm-workspace.yaml:46-46
Timestamp: 2025-08-07T04:00:59.627Z
Learning: In the lynx-family/lynx-stack repository, the webpack patch (patches/webpack5.101.0.patch) was created to fix issues with webpack5.99.9 but only takes effect on webpack5.100.0 and later versions. The patchedDependencies entry should use "webpack@^5.100.0" to ensure the patch applies to the correct version range.
Applied to files:
.github/workflows/nodejs-dependencies.yml
📚 Learning: 2025-08-06T13:28:57.139Z
Learnt from: colinaaa
PR: lynx-family/lynx-stack#1453
File: vitest.config.ts:49-61
Timestamp: 2025-08-06T13:28:57.139Z
Learning: In the lynx-family/lynx-stack repository, the file `packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/vitest.config.js` is a template file for scaffolding new Rspeedy projects, not a test configuration that should be included in the main vitest projects array.
Applied to files:
.github/workflows/relative-ci.yml
🪛 actionlint (1.7.7)
.github/workflows/code-scanning.yml
20-20: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
91-91: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/nodejs-dependencies.yml
24-24: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/pull-request-content-check.yml
17-17: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/relative-ci.yml
28-28: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/rust.yml
63-63: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
79-79: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/test.yml
33-33: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
199-199: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/workflow-bench.yml
16-16: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/workflow-build.yml
12-12: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/workflow-bundle-analysis.yml
13-13: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/workflow-website.yml
12-12: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🔇 Additional comments (1)
.github/workflows/test.yml (1)
33-34: Consolidate and whitelist custom runner labels
- Every changed job now uses
lynx-ubuntu-24.04-medium-verify; add this label once inactionlint.yaml(see first comment) to avoid repeated warnings.- With the label hard-coded in many places, a future change will be brittle. Consider a YAML anchor / reusable input to keep the label DRY:
- runs-on: lynx-ubuntu-24.04-medium-verify + runs-on: *linux-medium-verify # or ${{ inputs.runs-on }}(where
*linux-medium-verifyis defined at the top of the file).[ suggest_optional_refactor ]
Also applies to: 63-64, 116-117, 140-141, 168-169, 196-197, 199-200
| runs-on: lynx-ubuntu-24.04-medium-verify | ||
| timeout-minutes: 10 |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Whitelist the custom runner label in actionlint configuration
lynx-ubuntu-24.04-medium-verify is a self-hosted label, so actionlint (and any IDE integrations that rely on its rules) will keep flagging it as unknown until the label is explicitly whitelisted.
Add / update .github/actionlint.yaml (or the repo-root actionlint.yaml) accordingly:
+# .github/actionlint.yaml
+self-hosted-runner-labels:
+ - lynx-ubuntu-24.04-medium-verify
+ - lynx-ubuntu-24.04-xlarge-verify # list any other custom sizes you use
+ - lynx-custom-container # already referenced elsewhereAlso applies to: 79-80
🧰 Tools
🪛 actionlint (1.7.7)
63-63: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🤖 Prompt for AI Agents
In .github/workflows/rust.yml at lines 63-64 and also lines 79-80, the custom
runner label 'lynx-ubuntu-24.04-medium-verify' is used but not whitelisted in
the actionlint configuration, causing it to be flagged as unknown. To fix this,
update the .github/actionlint.yaml or the root actionlint.yaml file to
explicitly whitelist this custom runner label under the appropriate section for
runner labels, ensuring actionlint and IDE integrations recognize it as valid.
| @@ -13,7 +13,7 @@ jobs: | |||
| # Error: Event merge_group is not supported by CodSpeed | |||
| # Error: unknown variant `merge_group`, expected one of `push`, `pull_request`, `workflow_dispatch`, `schedule`, `local` at line 1 column 13 | |||
| if: github.event_name != 'merge_group' | |||
| runs-on: lynx-ubuntu-24.04-xlarge | |||
| runs-on: lynx-ubuntu-24.04-medium-verify | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Custom runner needs explicit self-hosted label and actionlint whitelisting
The label lynx-ubuntu-24.04-medium-verify is not recognised by GitHub-hosted runners, so the job must advertise itself as self-hosted (and/or be whitelisted for actionlint).
- runs-on: lynx-ubuntu-24.04-medium-verify
+ runs-on:
+ - self-hosted # lets GitHub dispatch to private fleet
+ - lynx-ubuntu-24.04-medium-verifyIf you rely on actionlint in CI, add the label to .github/actionlint.yaml:
runner-label:
- lynx-ubuntu-24.04-medium-verifyAlso verify that downgrading this benchmark job from the previous xlarge class to medium still finishes within the 10-minute timeout.
I’ll verify the current workflow and actionlint config before updating the comment.
🏁 Script executed:
#!/bin/bash
set -eux
# Show the runs-on line in the bench workflow
rg -n "runs-on" .github/workflows/workflow-bench.yml || true
sed -n '1,50p' .github/workflows/workflow-bench.yml || true
# Check if actionlint config exists and list its runner-label entries
if [ -f .github/actionlint.yaml ]; then
echo "Found .github/actionlint.yaml:"
grep -R "runner-label" -n .github/actionlint.yaml || echo "No runner-label key present"
sed -n '1,200p' .github/actionlint.yaml
else
echo ".github/actionlint.yaml not found"
fiLength of output: 1910
Ensure custom runner is recognized by GitHub and actionlint
The job currently specifies a custom runner label without advertising itself as self-hosted and there’s no actionlint config to whitelist it. Please:
- Update
.github/workflows/workflow-bench.ymlto include theself-hostedlabel so GitHub dispatches it to your private fleet. - Create or update
.github/actionlint.yamlto whitelist thelynx-ubuntu-24.04-medium-verifylabel. - Verify that switching from the previous “xlarge” class to “medium” still completes within the 10-minute timeout.
Suggested changes:
--- a/.github/workflows/workflow-bench.yml
+++ b/.github/workflows/workflow-bench.yml
@@ lines:16
-runs-on: lynx-ubuntu-24.04-medium-verify
+runs-on:
+ - self-hosted # allow dispatch to private fleet
+ - lynx-ubuntu-24.04-medium-verifyAdd an actionlint config if you don’t have one yet:
# .github/actionlint.yaml
runner-label:
- lynx-ubuntu-24.04-medium-verify🧰 Tools
🪛 actionlint (1.7.7)
16-16: label "lynx-ubuntu-24.04-medium-verify" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🤖 Prompt for AI Agents
In .github/workflows/workflow-bench.yml at line 16, the runner label lacks the
required 'self-hosted' tag, so update the runs-on value to include 'self-hosted'
along with 'lynx-ubuntu-24.04-medium-verify'. Additionally, create or update the
.github/actionlint.yaml file to whitelist the 'lynx-ubuntu-24.04-medium-verify'
label by adding a runner-label section with this label. Finally, after making
these changes, verify that the job completes within the 10-minute timeout
despite switching from the previous 'xlarge' runner class to 'medium'.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #1470 will not alter performanceComparing Summary
|
|
Closed since we have already supported 3.327.1. See: #1525 |
check the new version(3.327.1) runner for lynx-stack
Summary by CodeRabbit