fix(web): fix: && use getter to get. #1466

Sherry-hue · 2025-08-07T12:19:50Z

Summary by CodeRabbit

Bug Fixes
- Improved reliability of module callbacks to ensure they are accessed dynamically, enhancing stability for features relying on native and NAPI module calls.

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2025-08-07T12:19:54Z

🦋 Changeset detected

Latest commit: 5e741b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@lynx-js/web-core	Patch
@lynx-js/web-core-server	Patch
@lynx-js/web-constants	Patch
@lynx-js/web-mainthread-apis	Patch
@lynx-js/web-worker-rpc	Patch
@lynx-js/web-worker-runtime	Patch
@lynx-js/web-style-transformer	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-08-07T12:21:19Z

📝 Walkthrough

Walkthrough

This change updates the LynxView class in the @lynx-js/web-core package to access onNativeModulesCall and onNapiModulesCall via their getter methods instead of direct property access. No public API signatures were altered, and the overall logic remains unchanged.

Changes

Cohort / File(s)	Change Summary
Changeset for Patch Release `.changeset/short-taxis-smash.md`	Adds a patch changeset describing the switch to getter-based access for module call properties.
LynxView Callback Access Update `packages/web-platform/web-core/src/apis/LynxView.ts`	Modifies internal references to use the `onNativeModulesCall` and `onNapiModulesCall` getters in `#render`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

fix(web): onNativeModulesCall should use promise to return ret #1457: Also modifies the handling and caching logic of onNativeModulesCall in LynxView.ts, indicating a direct connection to this PR's focus on getter-based access.

Suggested reviewers

Sherry-hue

Poem

A rabbit hopped through LynxView’s code,
Swapping fields for getters in careful mode.
No logic lost, no API changed—
Just tidier access, neatly arranged.
With every patch, the garden grows—
Onward the clever bunny goes! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e741b8 and c49e0a5.

📒 Files selected for processing (2)

.changeset/short-taxis-smash.md (1 hunks)
packages/web-platform/web-core/src/apis/LynxView.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

packages/web-platform/web-core/src/apis/LynxView.ts
.changeset/short-taxis-smash.md

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codspeed-hq · 2025-08-07T12:32:53Z

CodSpeed Performance Report

Merging #1466 will not alter performance

_{Comparing Sherry-hue:fix/native-modules-usage (c49e0a5) with main (ead12c9)}

Summary

✅ 10 untouched benchmarks

relativeci · 2025-08-07T12:47:10Z

React Example

#3887 Bundle Size — 235.26KiB (0%).

c49e0a5(current) vs fb7096b main#3885(baseline)

Bundle metrics no changes

	Current #3887	Baseline #3885
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`159`	`159`
Duplicate Modules	`64`	`64`
Duplicate Code	`45.81%`	`45.81%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #3887	Baseline #3885
IMG	`145.76KiB`	`145.76KiB`
Other	`89.5KiB`	`89.5KiB`

Bundle analysis report Branch Sherry-hue:fix/native-modules-us... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2025-08-07T12:54:29Z

Web Explorer

#3883 Bundle Size — 342.71KiB (-0.23%).

c49e0a5(current) vs fb7096b main#3881(baseline)

Bundle metrics

4 changes

1 improvement

	Current #3883	Baseline #3881
Initial JS	`142.4KiB`(`-0.38%`)	`142.95KiB`
Initial CSS	`31.84KiB`	`31.84KiB`
Cache Invalidation	`50.51%`	`50.4%`
Chunks	`7`	`7`
Assets	`7`	`7`
Modules	`212`(`+0.47%`)	`211`
Duplicate Modules	`17`	`17`
Duplicate Code	`3.96%`(`-0.25%`)	`3.97%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 improvement

	Current #3883	Baseline #3881
JS	`227.91KiB` (`-0.34%`)	`228.69KiB`
Other	`82.95KiB`	`82.95KiB`
CSS	`31.84KiB`	`31.84KiB`

Bundle analysis report Branch Sherry-hue:fix/native-modules-us... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

codecov · 2025-08-07T13:18:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @lynx-js/[email protected] ### Patch Changes - Supports `recyclable` attribute in `<list-item>` to control whether the list item is recyclable. The `recyclable` attribute depends on Lynx Engine 3.4 or later. ([#1388](#1388)) ```jsx <list-item recyclable={false} /> ``` - feat: Support using a host element as direct child of Suspense ([#1455](#1455)) - Add profile in production build: ([#1336](#1336)) 1. `diff:__COMPONENT_NAME__`: how long ReactLynx diff took. 2. `render:__COMPONENT_NAME__`: how long your render function took. 3. `setState`: an instant trace event, indicate when your setState was called. NOTE: `__COMPONENT_NAME__` may be unreadable when minified, setting `displayName` may help. - Add `onBackgroundSnapshotInstanceUpdateId` event on dev for Preact Devtools to keep the correct snapshotInstanceId info. ([#1173](#1173)) - fix: Prevent error when spreading component props onto an element ([#1459](#1459)) - fix: Correctly check for the existence of background functions in MTS ([#1416](#1416)) ```ts function handleTap() { "main thread"; // The following check always returned false before this fix if (myHandleTap) { runOnBackground(myHandleTap)(); } } ``` ## @lynx-js/[email protected] ### Patch Changes - Remove the experimental `provider` option. ([#1432](#1432)) - Add `output.filename.wasm` and `output.filename.assets` options. ([#1449](#1449)) - fix deno compatibility ([#1412](#1412)) - Should call the `api.onCloseBuild` hook after the build finished. ([#1446](#1446)) - Bump Rsbuild v1.4.15. ([#1423](#1423)) - Support using function in `output.filename.*`. ([#1449](#1449)) ## [email protected] ### Patch Changes - Support ESLint for ReactLynx templates ([#1274](#1274)) ## @lynx-js/[email protected] ### Patch Changes - Updated dependencies \[[`c8ce6aa`](c8ce6aa)]: - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - Fix the `Package subpath './compat' is not defined by "exports"` error. ([#1460](#1460)) ## @lynx-js/[email protected] ### Patch Changes - Fix `GlobalEventEmitter` type definition, the `emit(eventName: string, data: unknown)` function should recevie an array typed `data` and pass as param list of listeners. ([#1479](#1479)) ## @lynx-js/[email protected] ### Patch Changes - fix: load main-thread chunk in ESM format ([#1437](#1437)) See [nodejs/node#59362](nodejs/node#59362) for more details. - feat: support path() for `createQuerySelector` ([#1456](#1456)) - Added `getPathInfo` API to `NativeApp` and its cross-thread handler for retrieving the path from a DOM node to the root. - Implemented endpoint and handler registration in both background and UI threads. - Implemented `nativeApp.getPathInfo()` - Updated dependencies \[]: - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - fix: load main-thread chunk in ESM format ([#1437](#1437)) See [nodejs/node#59362](nodejs/node#59362) for more details. - feat: support path() for `createQuerySelector` ([#1456](#1456)) - Added `getPathInfo` API to `NativeApp` and its cross-thread handler for retrieving the path from a DOM node to the root. - Implemented endpoint and handler registration in both background and UI threads. - Implemented `nativeApp.getPathInfo()` - fix: when `onNativeModulesCall` is delayed in mounting, the NativeModules execution result may be undefined. ([#1457](#1457)) - fix: `onNativeModulesCall` && `onNapiModulesCall` use getter to get. ([#1466](#1466)) - Updated dependencies \[[`29434ae`](29434ae), [`fb7096b`](fb7096b)]: - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - fix: load main-thread chunk in ESM format ([#1437](#1437)) See [nodejs/node#59362](nodejs/node#59362) for more details. ## @lynx-js/[email protected] ### Patch Changes - feat: add autocomplete attribute support for x-input component ([#1444](#1444)) Implements autocomplete attribute forwarding from the x-input custom element to the internal HTML input element in the shadow DOM. This enables standard browser autocomplete functionality for x-input elements. - Add referrerpolicy attribute support to x-image web component ([#1420](#1420)) - Updated dependencies \[]: - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - fix: load main-thread chunk in ESM format ([#1437](#1437)) See [nodejs/node#59362](nodejs/node#59362) for more details. - Updated dependencies \[[`29434ae`](29434ae), [`fb7096b`](fb7096b)]: - @lynx-js/[email protected] - @lynx-js/[email protected] ## @lynx-js/[email protected] ### Patch Changes - feat: support path() for `createQuerySelector` ([#1456](#1456)) - Added `getPathInfo` API to `NativeApp` and its cross-thread handler for retrieving the path from a DOM node to the root. - Implemented endpoint and handler registration in both background and UI threads. - Implemented `nativeApp.getPathInfo()` - Updated dependencies \[[`29434ae`](29434ae), [`fb7096b`](fb7096b)]: - @lynx-js/[email protected] - @lynx-js/[email protected] - @lynx-js/[email protected] ## [email protected] ## @lynx-js/[email protected] ## @lynx-js/[email protected] ## @lynx-js/[email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Sherry-hue self-assigned this Aug 7, 2025

Sherry-hue requested a review from PupilTong as a code owner August 7, 2025 12:19

Sherry-hue added this to Lynx for Web Aug 7, 2025

Sherry-hue added the platform:Web label Aug 7, 2025

PupilTong approved these changes Aug 7, 2025

View reviewed changes

fix(web): fix: && use getter to get.

c49e0a5

PupilTong force-pushed the fix/native-modules-usage branch from 5e741b8 to c49e0a5 Compare August 7, 2025 13:06

PupilTong enabled auto-merge (squash) August 8, 2025 03:09

PupilTong merged commit ed2ddcc into lynx-family:main Aug 8, 2025
111 of 123 checks passed

github-project-automation bot moved this to Done in Lynx for Web Aug 8, 2025

github-actions bot mentioned this pull request Aug 8, 2025

chore: Release 2025-08-09 04:27:19 #1434

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(web): fix: && use getter to get. #1466

fix(web): fix: && use getter to get. #1466

Uh oh!

Sherry-hue commented Aug 7, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Aug 7, 2025

Uh oh!

coderabbitai bot commented Aug 7, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem