Fix FingerUp causing UITouch to end in start location #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsoojin
force-pushed
the
fix-finger-up
branch
from
18bee1c to
1fcbb99
Compare
nsoojin
force-pushed
the
fix-finger-up
branch
from
1fcbb99 to
bbead4f
Compare
gabriellanata
previously approved these changes
Dec 8, 2021
nsoojin
force-pushed
the
fix-finger-up
branch
from
b19e8b8 to
3c83b4f
Compare
gabriellanata
approved these changes
Dec 10, 2021
Contributor
Author
|
hey @gabriellanata, |
Contributor
Yes sorry, had to fix CI |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gabriellanata Hey buddy,
There is a a bug in fingerUp where the location in touchesEnded callback is the start position of the drag(e.g. fingerDown). It is because FingerInfo only holds the initial location of the finger, so when I call fingerUp, it will cause the final touch on the initial point, not where the drag has ended.
To reproduce, comment out this line and run the DragTests I put in.
Once again, I greatly appreciate this library you put together. It has opened up fantastic automated testing suites for my app.