Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the Pull Request
A general overview of the changes can be found in the first commit message, which I'll paste down below
Commit message
Provided a working CMakeLists.txt file to build all of the examples,
also fixed a bunch of bugs (some fixes also depend on personal
preference and should be reviewed by maintainers):
screen resolution will be more than 2^32, this way we save 4 bytes
and we have faster comparisons
comparison warnings (for loops that worked with fbgl_point were
already working with int32_t in practice)
instead of an empty for loop, as that was optimized away in release
builds and led to all the animation being played instantly
incorrect w.r.t the actual function definition
possibly allowing for compiler optimizations
checks in release builds, for faster performance (This has been adapted to FBGL_VALIDATE_PUT_PIXEL, according to
master
, I still suggest DEBUG so it can be done automatically by CMake)fbgl_check_esc_key does not give any more warnings
All examples have been tested (on my local machine, so take this with a
grain of salt)
Additional Changes
The
example
directory has been renamed intoexamples
, files that have not been affected past that in this PR will show in the "files changed" tab as if the whole file was rewritten (this is how git sees renaming)Formatting has been applied in line with the
.clang-format
so there should not be any more useless diffs from now on.