Added functionality of programmatic Inc/Dec Page Number + Update Docs + Checkbox fix +Disabled Switch CSS fix + Sidebar ClickNotClose Issue fixed #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-solanki
changed the title
jd-solanki
changed the title
jd-solanki
changed the title
| @@ -92,7 +92,7 @@ export default { | |||
| this.setValueString() | |||
| } | |||
| else { | |||
| this.$emit('input', evt.target.value) | |||
| this.$emit('input',!this.value) | |||
There was a problem hiding this comment.
It does NOT work with what you updated in this line
There was a problem hiding this comment.
I tested that in doc. In my clone it worked so. Anyway, I will try once again. Because my project is running in production can you please find solution to this first. Because this is MAJOR issue.
Waiting for fix.
Thanks
There was a problem hiding this comment.
it is already solved apparently there is a conflict when adding input and change and they run together
Tofandel
pushed a commit
to Tofandel/fixed-vuesax
that referenced
this pull request
Apr 26, 2021
Added functionality of programmatic Inc/Dec Page Number + Update Docs + Checkbox fix +Disabled Switch CSS fix + Sidebar ClickNotClose Issue fixed
Tofandel
pushed a commit
to Tofandel/fixed-vuesax
that referenced
this pull request
Apr 26, 2021
Added functionality of programmatic Inc/Dec Page Number + Update Docs + Checkbox fix +Disabled Switch CSS fix + Sidebar ClickNotClose Issue fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added functionality to update page number from outside of pagination component.
Here's what it looks like.
I have tested it there's no bug even if there's negative value or value is greater than total pages.
This solves my issue
i also fixed checkbox issue & This one
New Fix: Fixed disabled switch CSS issue
Sidebar component's click-not-close prop was broken. Fixed.