Add icon library support #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed docs uses of `<i>` elements and cleaned up a few lingering display issues related to the `<vs-icon>` conversion.
|
@jacrys you can remove this conflicts? ty |
|
@jacrys hi hi, can you resolve this conflicts? |
|
Sorry @brunokunace, this hung for a while, I wasn't getting GH notifications for a time, and I have been dealing with tight deadlines at work. I have some leave coming up in the next week, and will get on this when I get a chance. |
|
any news with conflict? |
…support Resolve merge conflicts
|
@brunokunace @luisDanielRoviraContreras all conflicts should be resolved. I apologize for the time this took me. I have rebased this on master, so all current live changes should be present. I would rather someone look over this quickly than merge myself. |
Tofandel
pushed a commit
to Tofandel/fixed-vuesax
that referenced
this pull request
Apr 26, 2021
Add icon library support
Tofandel
pushed a commit
to Tofandel/fixed-vuesax
that referenced
this pull request
Apr 26, 2021
Add icon library support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made required changes to code