Support passing Element into loading container property #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows passing
Element
as thecontainer
property for the first parameter ofVue.prototype.$vs.loading
Rationale
Refs provide a direct link to the DOM that your component uses, using ID's in Vue is dangerous since components can be spun up and multiple ID's can exist.
Using the Vue ref api we can pass the element itself into the loader to yield a more precise and predictable behavior
Backwards Compatibility
This change is backwards compatible.
Example