Use case insensitive headers

[motss]

polka/packages/send-type/index.js

Line 3 in a9f0f58

const TYPE = 'Content-Type';

According to https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2, HTTP headers are case insensitive. Thus, it should also handle 'content-type'.

[lukeed]

Yo!

So this only matches case-sensitive for the headers you manually provide into the last argument. This is done as I most commonly saw Express developers use capitalized forms in their applications.

Once the helper reaches these two places:

polka/packages/send-type/index.js

Line 10 in a9f0f58

res.setHeader(TYPE, type || OSTREAM);

polka/packages/send-type/index.js

Line 26 in a9f0f58

res.writeHead(code, headers);

... Node automatically lowercases any/all keys it received.

[motss]

Yeah and I happen to be a portion of them who using everything lowercase in all kind of headers.

send(res, 200, { 'content-type': 'application/json' });

It took me quite a while to figure this out until I look at the code. Any plan to resolve this?

[lukeed]

Hey @motss, sorry for the delay on this. This will be working for you in the next release 😄

I just lowercased any/all header keys that were passed into send before continuing any logic. If you get a chance to look at it that'd be awesome. Thanks!

[motss]

LGTM! Really appreciate the fix.

[T1MOXA]

What cat I do if I need to send response with uppercase letters ?

[lukeed]

You should use @polka/send@next :: https://github.com/lukeed/polka/blob/next/packages/send/index.js

It still reads your header values without caring about case, but it will write output headers with capital casing.

You should also fix/report an issue with your HTTP client, because it's supposed to not matter

[T1MOXA]

polka/packages/send/index.js

Line 11 in d0c3863

obj[k.toLowerCase()] = headers[k];

Makes header key lowercase.

[lukeed]

polka/packages/send/index.js

Line 30 in d0c3863

obj[TYPE] = type || 'text/plain';

[T1MOXA]

I'm not talking about the content type, I have a problem with custom headers like
{ "Example-Header": "some value" }

[lukeed]

Ah sorry, you didn't specify.

Then I wouldn't include them inside the send object.
Instead you could do res.setHeader('Example-Header', 'value'). It's a little more verbose, but IMO that's the price you should probably have to pay for requiring non-standard/spec'd behavior. Again, whatever is reading your HTTP headers is supposed to be case-insensitive.

[T1MOXA]

Yes, this is an option, but it would be better if send allowed you to do this without setHeader

[lukeed]

Sorry, I'm really not inclined to support this. I don't want to lock in/promise vanity behavior that shouldn't be there in the first place. Forces Polka to continue that (almost) indefinitely when, again, the HTTP spec says it's not supposed to matter.

[T1MOXA]

Ок, anyway thanks for reply and cool lib :)