Feat/pt 126 #71
Merged
Feat/pt 126 #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzunglee
reviewed
Jun 7, 2022
| @@ -198,8 +192,8 @@ export default defineComponent({ | |||
| const dialogFormVisible = ref(false) | |||
| const formLabelWidth = '140px' | |||
| const form = reactive({ | |||
| email: '', | |||
| password: '', | |||
| email: '[email protected]', | |||
There was a problem hiding this comment.
Để mặc định email làm gì thế anh nhỉ
There was a problem hiding this comment.
Bản demo khi load vào có chữ đã nhập dạng lưu cache, nên anh hard code để giống demo. Vậy chỗ này mình xóa được không em?
| @@ -7,38 +7,41 @@ body { | |||
| @apply shadow rounded overflow-hidden; | |||
| } | |||
|
|
|||
| .form-icon { | |||
| @apply bg-white w-15/100; | |||
| .el-form .form-icon { | |||
There was a problem hiding this comment.
Dùng % set width có thể responsive không đúng đâu anh nhé
src/assets/css/form.scss
Outdated
| } | ||
| .el-input.el-input--default { | ||
| @apply w-85/100; | ||
| @apply w-[88%]; |
There was a problem hiding this comment.
Đây nữa anh nhé, nên dùng flex css
Trung-Hieu-Dev
force-pushed
the
feat/PT-126
branch
from
1c92dac to
79df377
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
dzunglee
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.