DM-52550: Fix Starlette deprecation warning #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starlette deprecated the `HTTP_422_UNPROCESSABLE_ENTITY` constant and changed it to `HTTP_422_UNPROCESSABLE_CONTENT` in [this PR](Kludex/starlette#2939). We could either change this constant in our code, or just use the status code int directly. This PR uses status code directly here rather than the new constant in to avoid having to increase the lower bound on starlette. This is the choice that the FastAPI folks made in [this PR](https://github.com/fastapi/fastapi/pull/14077/files).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starlette deprecated the
HTTP_422_UNPROCESSABLE_ENTITYconstant and changed it toHTTP_422_UNPROCESSABLE_CONTENTin this PR. We could either change this constant in our code, or just use the status code int directly.This PR uses status code directly here rather than the new constant in to avoid having to increase the lower bound on starlette. This is the choice that the FastAPI folks made in this
PR.