Skip to content

Conversation

flbrgit
Copy link

@flbrgit flbrgit commented Oct 3, 2025

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
  • I strictly followed the principle of data economy for all client-server REST calls.
  • I strictly followed the client coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

This PR addresses the need for supporting privacy-sensitive prompts within Iris. It adds the possibility to choose between local and cloud-hosted models, giving users a free choice to select a privacy level that suits them best.

Description

Inside the Iris-Chatbot-Component, a toggle-Button was added to enable or disable the usage of cloud-hosted LLMs. This value is send to Iris within a new header field called isCloudEnabled.

Steps for Testing

Prerequisites:

  • 1 Student
  1. Log in to Artemis
  2. Navigate to an exercise with Iris enabled
  3. Open the developer tools of your browser and observe the network tab
  4. Try out the toggle button and send messages with cloud enabled and disabled
  5. Check if Artemis correctly sends requests to Iris including the header "isCloudEnabled=false" or "isCloudEnabled=true", respectively

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Performance Tests

  • Test 1
  • Test 2

Test Coverage

Screenshots

@flbrgit flbrgit self-assigned this Oct 3, 2025
@github-project-automation github-project-automation bot moved this to Work In Progress in Artemis Development Oct 3, 2025
@flbrgit flbrgit added enhancement client Pull requests that update TypeScript code. (Added Automatically!) iris Pull requests that affect the corresponding module labels Oct 3, 2025
@flbrgit flbrgit marked this pull request as ready for review October 3, 2025 12:49
@flbrgit flbrgit requested a review from a team as a code owner October 3, 2025 12:49
@flbrgit flbrgit marked this pull request as draft October 3, 2025 12:50
@flbrgit flbrgit requested a review from a team October 3, 2025 12:52
Copy link
Contributor

coderabbitai bot commented Oct 3, 2025

Caution

Review failed

The head commit changed during the review from af9a4d5 to 59515bb.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/logos-select-llm-privacy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

github-actions bot commented Oct 3, 2025

End-to-End (E2E) Test Results Summary

TestsPassed ☑️Skipped ⚠️Failed ❌️Time ⏱
End-to-End (E2E) Test Report205 ran201 passed3 skipped1 failed1h 16m 206ms
TestResultTime ⏱
End-to-End (E2E) Test Report
e2e/exercise/quiz-exercise/QuizExerciseManagement.spec.ts
ts.Quiz Exercise Management › Quiz Exercise Creation › Creates a Quiz with Drag and Drop❌ failure2m 5s 509ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) enhancement iris Pull requests that affect the corresponding module
Projects
Status: Work In Progress
Development

Successfully merging this pull request may close these issues.

1 participant