-
Notifications
You must be signed in to change notification settings - Fork 344
Development
: Fix git SSH URI generation for build agents
#11447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving code
WalkthroughUpdated SSH URI construction in AbstractGitService.getSshUri to use the repository URI path unchanged, removing previous logic that stripped a leading "/scm" segment. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
End-to-End (E2E) Test Results Summary
|
End-to-End (E2E) Test Results Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm
Checklist
General
Server
Motivation and Context
We currently have a bug in an Artemis course with the short name
scml2526
on production.All build jobs for programming exercises are failing because of this error:
After having a look at the server logs, we discovered that the build agent tried to clone with this URI:
ssh://[email protected]:7921/git/SCML2526TSTl2526tst-solution.git
. The URI should look like this:ssh://[email protected]:7921/git/SCML2526TST/scml2526tst-solution.git
.The reason for this is that
/scm
is removed in the SSH clone URI (probably a relic from Bitbucket).Description
We removed that
/scm
is replaced with""
.Steps for Testing
Prerequisites:
Optionally you can test this locally (when having SSH enabled for the build agent):
scml2526
Testserver States
You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.
Review Progress
Code Review
Manual Tests
Summary by CodeRabbit