-
Notifications
You must be signed in to change notification settings - Fork 344
Development
: Remove delete all exam room versions
#11441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Remove delete all exam room versions
#11441
Conversation
WalkthroughRemoval of the “delete all exam rooms” functionality across backend, frontend, and tests. Eliminated the service methods, REST endpoint, UI button, dialog handling, and associated tests. Updated i18n keys and adjusted wording for the safe delete action. Other endpoints and features remain unchanged. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Admin as Admin UI
participant FE as Frontend Service
participant BE as AdminExamResource
participant SVC as ExamRoomService
participant DB as Database
rect rgba(240,240,255,0.6)
note over Admin,BE: Removed flow (Delete All Exam Rooms)
Admin->>FE: click "Delete All Exam Rooms" (removed)
FE--xBE: DELETE /exam/admin/exam-rooms (removed)
BE--xSVC: deleteAllExamRooms() (removed)
SVC--xDB: purge all rooms (removed)
end
rect rgba(240,255,240,0.6)
note over Admin,BE: Existing flow retained (Delete outdated and unused)
Admin->>FE: click "Delete outdated and unused"
FE->>BE: DELETE /exam/admin/exam-rooms/outdated-and-unused
BE->>SVC: deleteOutdatedAndUnusedExamRooms()
SVC->>DB: remove targeted versions
DB-->>SVC: result
SVC-->>BE: ok
BE-->>FE: 204 No Content
FE-->>Admin: refresh overview
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
End-to-End (E2E) Test Results Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code: looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code 👍
Exam mode
: Remove the 'Delete all exam room versions' featureDevelopment
: Remove delete all exam room versions
Checklist
General
Client
Motivation and Context
Currently we allow an admin to delete all exam rooms, i.e. all versions of all exam rooms, including the most recent ones. This PR aims to remove that functionality, as it is not a proper use-case, as such a removal would also need to notify every course instructor. A feature to remove the newest version of a single room can be implemented in a future PR if desired.
Description
Removed everything related to the 'Delete all exam rooms' feature/button on the admin's
Exam Room
server administration tab .Also slightly adapted the text of the other deletion button to better reflect what it does.
Steps for Testing
Testing is not required, as the only thing that could be tested is the absence of a button, which I did locally.
Review Progress
Code Review
Summary by CodeRabbit