-
Notifications
You must be signed in to change notification settings - Fork 344
Development
: Replace bootstrap components with primeng in calendar
#11415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Replace bootstrap components with primeng in calendar
#11415
Conversation
General
: Replace Bootstrap controls with PrimeNG controls in calendarGeneral
: Replace Bootstrap components with PrimeNG components in calendar
End-to-End (E2E) Test Results Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test on laptop re-approved
End-to-End (E2E) Test Results Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-Tested on mobile. Still works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving code. Thanks for the changes!
61f50e0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove after fixing merge conflicts
General
: Replace Bootstrap components with PrimeNG components in calendarDevelopment
: Replace bootstrap components with primeng components in calendar
Development
: Replace bootstrap components with primeng components in calendarDevelopment
: Replace bootstrap components with primeng in calendar
Checklist
General
Client
Motivation and Context
I initially implemented the calendar feature using a few bootstrap components. To improve UI/UX we want to use PrimeNG components in the future.
Description
This PR replaces all Bootstrap components used in the calendar feature with PrimeNG components. I mainly replaced controls (such as buttons) and popovers. I also adapted the tests to work with the new setup.
Steps for Testing
Testserver States
You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.
Review Progress
Code Review
Manual Tests
Test Coverage
Client
Screenshots
Summary by CodeRabbit
New Features
Refactor
Style
Chores