`Development`: Store shorter repository URI in database #11376

tobias-lippert · 2025-09-11T21:27:08Z

Only deploy to TS1!

Checklist

General

I tested all changes and their related features with all corresponding user types on a test server.
Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
I chose a title conforming to the naming conventions for pull requests.

Server

Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
I strictly followed the server coding and design guidelines.
I added multiple integration tests (Spring) related to the features (with a high test coverage).
I documented the Java code using JavaDoc style.

Changes affecting Programming Exercises

VCS is the same for all setups

Motivation and Context

We store a lot of redundant information in the repository_url column of each participation.
The server url, the /git/prefix and the .git suffix
This wastes space in the database.

Description

Adapted the getter and setters of the involved Uris to convert between the short and the full variant.
Adapted the tests where necessary

Steps for Testing

Prerequisites:

1 Instructor
1 Student
1 TS with LocalVC/LocalCI Setup (e.g. ts1)
Make sure that a programming exercise exists before deploying this PR that is started
Make sure that a programminge exercise exists before deploying this PR that is not yet started

Log in to Artemis
Navigate to Course Administration
Create a programming exercise with auxiliary repository
Download the template, solution, test and auxiliary repository and check the correct content is contained
As student, start the previously existing programming exercise and participate in it using your git client with both https and ssh, vcs access token and online code editor and make sure this succeeds
Participate in the already existing, started exercise with using your git client with both https and ssh, vcs access token and online code editor and make sure this succeeds
Do the same as in 5. for the newly created exercise

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Code Review

Code Review 1
Code Review 2

Manual Tests

Test 1
Test 2

Test Coverage

Class/File	Line Coverage	Confirmation (assert/expect)
RepositoryUriConversionUtil.java	89%	✅

Summary by CodeRabbit

Bug Fixes
- Improved repository detection and access logging by normalizing repository URLs (handles full vs. short forms and /git/ paths), reducing lookup and logging errors.
Refactor
- Repository URIs are now consistently presented as full URLs while stored in a compact form, improving interoperability across services.
Tests
- Expanded and hardened tests and test helpers to validate URL conversions and per-thread server URL handling for more stable parallel/local CI runs.

github-actions · 2025-09-12T12:38:31Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ✅	Skipped	Failed	Time ⏱
End-to-End (E2E) Test Report	1 ran	1 passed	0 skipped	0 failed	1s 489ms

Test	Result	Time ⏱
No test annotations available

RepositoryUriConversionUtil is now compatible with parallel test execution

…el test execution

tobias-lippert · 2025-09-15T09:22:15Z

src/test/java/de/tum/cit/aet/artemis/core/service/DataExportCreationServiceTest.java

        }
-        var participation = participationUtilService.addStudentParticipationForProgrammingExerciseForLocalRepo(programmingExercise, userLogin,
-                URI.create(LocalRepositoryUriUtil.convertToLocalVcUriString(programmingExerciseTestService.studentRepo.workingCopyGitRepoFile, localVCRepoPath)));
+        String shortUri = LocalRepositoryUriUtil.convertToLocalVcUriShortUriString(programmingExerciseTestService.studentRepo.workingCopyGitRepoFile, localVCRepoPath);


This pattern is used in different tests. It's needed because our local repositories use file paths as git repository uris which is kind of a hack and incompatible with our conversion mechansim because file paths are never used as repo uris in production. Therefore, we have to make the uris compatible while not breaking the usage of LocalRepository.
We do this by first extracting the short uri (projectName/repo-slug) from the file path and then converting it to a full repository uri because that's the value the production code will use the call the method. Without specifying the full repository uri, mocking won't work.

github-actions · 2025-09-29T09:42:36Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	205 ran	200 passed	3 skipped	2 failed	1h 13m 42s 172ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/exercise/quiz-exercise/QuizExerciseManagement.spec.ts
ts.Quiz Exercise Management › Quiz Exercise Creation › Creates a Quiz with Drag and Drop	❌ failure	2m 6s 287ms
e2e/exercise/programming/ProgrammingExerciseStaticCodeAnalysis.spec.ts
ts.Static code analysis tests › Configures SCA grading and makes a successful submission with SCA errors	❌ failure	2m 25s 339ms

ekayandan

Tested on TS1. Changes work with new exercises. Existing exercises do not show template and solution repository urls.

bensofficial

Reapprove DB migration

github-actions · 2025-09-29T13:15:13Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	205 ran	201 passed	3 skipped	1 failed	1h 19m 32s 916ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/exercise/quiz-exercise/QuizExerciseManagement.spec.ts
ts.Quiz Exercise Management › Quiz Exercise Creation › Creates a Quiz with Drag and Drop	❌ failure	2m 4s 580ms

ekayandan

Tested on TS1. When I navigate to an existing programming exercise, I can't download/view/participate in existing repositories.

github-actions · 2025-10-02T20:20:33Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	205 ran	200 passed	3 skipped	2 failed	1h 19m 13s 755ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/exercise/quiz-exercise/QuizExerciseManagement.spec.ts
ts.Quiz Exercise Management › Quiz Exercise Creation › Creates a Quiz with Drag and Drop	❌ failure	2m 4s 79ms
e2e/exercise/quiz-exercise/QuizExerciseParticipation.spec.ts
ts.Quiz Exercise Participation › DnD Quiz participation › Student can participate in DnD Quiz	❌ failure	2m 5s 676ms

github-actions · 2025-10-02T22:18:24Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	205 ran	199 passed	3 skipped	3 failed	1h 17m 18s 245ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/exercise/quiz-exercise/QuizExerciseManagement.spec.ts
ts.Quiz Exercise Management › Quiz Exercise Creation › Creates a Quiz with Drag and Drop	❌ failure	2m 3s 885ms
e2e/exercise/quiz-exercise/QuizExerciseParticipation.spec.ts
ts.Quiz Exercise Participation › DnD Quiz participation › Student can participate in DnD Quiz	❌ failure	2m 4s 488ms
e2e/exercise/programming/ProgrammingExerciseStaticCodeAnalysis.spec.ts
ts.Static code analysis tests › Configures SCA grading and makes a successful submission with SCA errors	❌ failure	2m 33s 227ms

bensofficial

Reapprove DB migration

tobias-lippert added 2 commits September 11, 2025 23:24

add logic to store shorter repo url in db

d69c150

start adapting tests

ce2b80f

github-project-automation bot added this to Artemis Development Sep 11, 2025

github-project-automation bot moved this to Work In Progress in Artemis Development Sep 11, 2025

github-actions bot assigned tobias-lippert Sep 11, 2025

tobias-lippert added this to the 8.4.1 milestone Sep 12, 2025

add repository conversion util to git

df20082

tobias-lippert added 10 commits September 13, 2025 21:48

use getter/setter consistently for template and solution repo

49c4901

121 tests failing

152b69a

debug log

88e6c57

34 failing tests

2cf36b2

RepositoryUriConversionUtil is now compatible with parallel test execution

do not convert to short uri before setting it

0d1b6d8

47 failing tests

94ba714

9 failing tests

87cd395

still 9 failing tests, different approach

065a5b6

try to make RepositoryUriConversionUtil really compatible with parall…

7bcd8b7

…el test execution

add solution to be threadsafe with @async

5fcd4f6

github-actions bot added athena Pull requests that affect the corresponding module core Pull requests that affect the corresponding module hyperion and removed iris Pull requests that affect the corresponding module labels Sep 14, 2025

make bean lazy

6fdcbd2

tobias-lippert commented Sep 15, 2025

View reviewed changes

Merge branch 'develop' into chore/shorter-repo-url

f8040d3

helios-aet bot temporarily deployed to artemis-test3.artemis.cit.tum.de September 29, 2025 08:48 Inactive

tobias-lippert dismissed stale reviews from ahmetsenturk, Hialus, paoxin, and coderabbitai[bot] via f8040d3 September 29, 2025 08:49

coderabbitai bot previously approved these changes Sep 29, 2025

View reviewed changes

ekayandan reviewed Sep 29, 2025

View reviewed changes

fix typo in db migration

afec7f1

tobias-lippert dismissed coderabbitai[bot]’s stale review via afec7f1 September 29, 2025 12:21

coderabbitai bot previously approved these changes Sep 29, 2025

View reviewed changes

bensofficial previously approved these changes Sep 29, 2025

View reviewed changes

helios-aet bot temporarily deployed to artemis-test1.artemis.cit.tum.de September 29, 2025 12:51 Inactive

helios-aet bot temporarily deployed to artemis-test1.artemis.cit.tum.de September 30, 2025 05:39 Inactive

helios-aet bot temporarily deployed to artemis-test1.artemis.cit.tum.de October 1, 2025 09:59 Inactive

helios-aet bot temporarily deployed to artemis-test1.artemis.cit.tum.de October 1, 2025 10:58 Inactive

ekayandan requested changes Oct 1, 2025

View reviewed changes

tobias-lippert modified the milestones: 8.4.1, 8.4.2 Oct 1, 2025

Merge branch 'develop' into chore/shorter-repo-url

73bc357

fixed changelog

de1cbbb

tobias-lippert dismissed stale reviews from bensofficial and coderabbitai[bot] via de1cbbb October 2, 2025 21:24

coderabbitai bot approved these changes Oct 2, 2025

View reviewed changes

bensofficial approved these changes Oct 3, 2025

View reviewed changes

helios-aet bot deployed to artemis-test1.artemis.cit.tum.de October 3, 2025 08:36 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

`Development`: Store shorter repository URI in database #11376

`Development`: Store shorter repository URI in database #11376

tobias-lippert commented Sep 11, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 12, 2025

Uh oh!

tobias-lippert Sep 15, 2025

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

ekayandan left a comment

Uh oh!

bensofficial left a comment

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

ekayandan left a comment

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

bensofficial left a comment

Uh oh!

Uh oh!

Development: Store shorter repository URI in database #11376

Are you sure you want to change the base?

Development: Store shorter repository URI in database #11376

Conversation

tobias-lippert commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Only deploy to TS1!

Checklist

General

Server

Changes affecting Programming Exercises

Motivation and Context

Description

Steps for Testing

Testserver States

Review Progress

Code Review

Manual Tests

Test Coverage

Summary by CodeRabbit

Uh oh!

github-actions bot commented Sep 12, 2025

End-to-End (E2E) Test Results Summary

Uh oh!

tobias-lippert Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 29, 2025

End-to-End (E2E) Test Results Summary

Uh oh!

ekayandan left a comment

Choose a reason for hiding this comment

Uh oh!

bensofficial left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 29, 2025

End-to-End (E2E) Test Results Summary

Uh oh!

ekayandan left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 2, 2025

End-to-End (E2E) Test Results Summary

Uh oh!

github-actions bot commented Oct 2, 2025

End-to-End (E2E) Test Results Summary

Uh oh!

bensofficial left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

`Development`: Store shorter repository URI in database #11376

`Development`: Store shorter repository URI in database #11376

tobias-lippert commented Sep 11, 2025 •

edited

Loading