-
Notifications
You must be signed in to change notification settings - Fork 345
Quiz exercises
: Practice Mode Migration
#11283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
End-to-End (E2E) Test Results Summary
|
End-to-End (E2E) Test Results Summary |
End-to-End (E2E) Test Results Summary
|
End-to-End (E2E) Test Results Summary
|
End-to-End (E2E) Test Results Summary
|
End-to-End (E2E) Test Results Summary
|
End-to-End (E2E) Test Results Summary
|
End-to-End (E2E) Test Results Summary |
AND r.rated = FALSE); | ||
</sql> | ||
|
||
<sql dbms="mysql"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might include h2
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DB migration looks good.
End-to-End (E2E) Test Results Summary |
Tested on TS6, worked as expected. |
End-to-End (E2E) Test Results Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS6, also code 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on TS6 worked as described
End-to-End (E2E) Test Results Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove DB migration
End-to-End (E2E) Test Results Summary |
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
097a543
End-to-End (E2E) Test Results Summary |
ONLY DEPLOY TO TS 6
Checklist
General
Server
Client
Motivation and Context
Currently all submissions for quiz exercises ([0-1] live submissions, [n] practice submissions) are all attached to a single participation. The only way to differentiate between live and practice submissions is to check if the result is rated. To make quizzes more consistent with programming exercises they should instead use the
testRun
attribute already contained in the Participation.Description
This PR changes Quiz Exercises so, that every student can have two participations for each quiz exercise:
To achieve this I adapted the
startPracticeMode
function in theParticipationService
, so that it now also works for Quiz Exercises and is no longer reserved only for Programming Exercises.The
submitForPractice
function in theQuizSubmissionResource
now utilizes thestartPracticeMode
instead of thestartExercise
function, reserving the latter one for live submissions.Steps for Testing
Prerequisites:
Testserver States
You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.
Review Progress
Performance Review
Code Review
Manual Tests
Summary by CodeRabbit
New Features
Bug Fixes
Improvements