[device_id] fix device ID string formatting util #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were several bugs in the device ID to hextstring util: 1. Si Creator ID should be 16 bits not 32. 2. Product ID should be 16 bits not 32. 3. SKU specific field should be 128 bits. Signed-off-by: Tim Trippel <[email protected]>
oshratza
approved these changes
Jul 10, 2025
Collaborator
oshratza
left a comment
oshratza
left a comment
There was a problem hiding this comment.
should the "0x" prefix be left?
Collaborator
Author
|
yes I believe so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several bugs in the device ID to hextstring util: