Create CI.yml #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This was accidentally introduced in D25334717 (Instagram@9cb16b0), at the time I didn't pay close attention to the impact there. The diff actually broke the CI for IGListKit in open source community since IGListDiffKit was meant to be compatible in both MacOS and iOS. The right approach is to rely on the IGListCompatibility.h to resolve the linked code here. Reviewed By: rzito Differential Revision: D30344334 fbshipit-source-id: 842ca560a1bfe6d54e7d90466575e4ed35cd9b87
Summary: ## Changes in this pull request - set header `IGListAdapterUpdaterCompatible.h` to - public which fixed Xcode 12 unit test iOS build. - include `IGListTransitionData.m` to tvOS trget which fixed Xcode 12 tvOS framework build. - Added GitHub workflow `CI`. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: Instagram#1478 Reviewed By: candance Differential Revision: D25504500 Pulled By: lorixx fbshipit-source-id: 91f477838f176f662dd74928b75df670a4106968
Summary: Run ``` bundle update slather ``` Differential Revision: D30349860 fbshipit-source-id: 9c7334125a4916e8ffd74556649c0570fa76a241
…lorixx-github-action * 'master' of https://github.com/Instagram/IGListKit: Fix the slather Run tests from Xcode12. Github workflow (Instagram#1478) Remove UIKit dependencies in IGListDiffKit code
…stKit into lorixx-github-action * 'lorixx-github-action' of https://github.com/lorixx/IGListKit: Fix the Gemfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Issue fixed: #
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.