ProxyAdded proxy option + proxy sanity checks #277
Conversation
lorenzodifuccia
left a comment
lorenzodifuccia
left a comment
There was a problem hiding this comment.
Hi @holzkohlengrill, thank you for the PR.
Could you please see the comment on the changed file?
safaribooks.py
Outdated
| if USE_PROXY: # DEBUG | ||
| self.session.proxies = PROXIES | ||
| self.session.verify = False | ||
| if args_parsed.proxies: |
There was a problem hiding this comment.
Use self.args instead of global args_parsed
There was a problem hiding this comment.
@lorenzodifuccia please check. I removed now completely the global arguments and packed it into some functions to avoid errors like this and make it more readable.
|
@lorenzodifuccia anything open or can we merge? |
|
Hi @holzkohlengrill, I thought I sent the request change, sorry 🤦🏻♂️ |
|
The Proxy args and code it's ok. |
|
I changed it because it was very messy and error prone due to a mix of global and local arguments, etc. |
2 participants
Added proxy option as a command line argument.
Added checks to make sure the proxy URL is valid.