Skip to content

test(testlab): verify how RequestContext combines urlBase and basePath #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bajtos merged 1 commit into from
Mar 15, 2019
Merged

test(testlab): verify how RequestContext combines urlBase and basePath #2589

bajtos merged 1 commit into from
Mar 15, 2019

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Mar 14, 2019

This is a follow-up for #2547 (comment).

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@bajtos bajtos added the REST Issues related to @loopback/rest package and REST transport in general label Mar 14, 2019
@bajtos bajtos self-assigned this Mar 14, 2019
@bajtos bajtos mentioned this pull request Mar 14, 2019
Merged
6 tasks
@bajtos bajtos merged commit 8a92537 into master Mar 15, 2019
@bajtos bajtos deleted the test/base-path-when-mounted branch March 15, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondfeng raymondfeng raymondfeng approved these changes

@hacksparrow hacksparrow Awaiting requested review from hacksparrow

Assignees

@bajtos bajtos

Labels

REST Issues related to @loopback/rest package and REST transport in general

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bajtos @raymondfeng