fix(cli): move sequence customization to app constructor #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, when saving changes to our CLI template files with `.ts.ejs` extension, VSCode squashed all content into a single line - not useful at all. After this change, VSCode does not reformat template files and preserves whatever formatting we have in place instead.
6 tasks
raymondfeng
approved these changes
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #1022 which re-introduced a bad practice of customizing app behavior in
app.start, something we are trying to get rid of (see e.g. #968 and #994).Checklist
npm testpasses on your machinepackages/cliwere updatedpackages/example-*were updated