-
Notifications
You must be signed in to change notification settings - Fork 17
feat(tencent-mail): add tencent mail connector #47
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Edit: hold on...
charIeszhao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at my comments, and let me know if you need any further discussion. Thanks!
659ea37 to
e6fec18
Compare
7280f72 to
9fc6091
Compare
wangsijie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind rebase master and update project structure? You can see other packages, the main change is package.extend.json. And if you need help, just call it out, our team can do this for you.
wangsijie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, what we need is only a README
wangsijie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But CI checks failed, seems like lock problem.
19be7cc to
b149c1a
Compare
b149c1a to
d807dc0
Compare
darcyYe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-Authored-By: Charles Zhao <[email protected]>
Co-Authored-By: Charles Zhao <[email protected]>
d5c522c to
0b85ea5
Compare
|
thanks for contributing @StringKe. we're going to archive this repo in favor of the connectors directory in the Logto monorepo. |
Summary
https://cloud.tencent.com/product/ses
Testing
local test, send mail suucess