Handle state file symlink #664
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the state file is a symlink override the target and create the temporary file in the targets parent directory instead of the symlink itself. Only follows one level of symlink. Improves: logrotate#581
kdudka
requested changes
Apr 14, 2025
There was a problem hiding this comment.
I am afraid this would introduce a security weakness in case the symlink (or the directory where it resides) is write-accessible by a non-privileged user. If logrotate runs with root privileges, a non-privileged user would be able to overwrite files they do not have otherwise write access to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the state file is a symlink override the target and create the temporary file in the targets parent directory instead of the symlink itself.
Only follows one level of symlink.
Improves: #581