Skip to content

Fix ingestion job config dict with null value #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2021
Merged

Fix ingestion job config dict with null value #226

merged 2 commits into from
Jan 25, 2021

Conversation

moritzmeister
Copy link
Contributor

I had a case where the dict contains the field but with value None so the pop returns None instead of the default {}.

@SirOibaf SirOibaf merged commit 1c0db64 into logicalclocks:master Jan 25, 2021
@moritzmeister moritzmeister deleted the util-fix branch February 2, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SirOibaf SirOibaf SirOibaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moritzmeister @SirOibaf