Skip to content

Conversation

tjx666
Copy link
Collaborator

@tjx666 tjx666 commented Sep 25, 2025

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • ✅ test
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

refs:

Copy link

vercel bot commented Sep 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lobe-chat-database Ready Ready Preview Comment Oct 8, 2025 9:58am
lobe-chat-preview Error Error Oct 8, 2025 9:58am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
lobe-chat-for-mobile Ignored Ignored Preview Oct 8, 2025 9:58am

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 25, 2025
Copy link
Contributor

gru-agent bot commented Sep 25, 2025

TestGru Assignment

Summary

Link CommitId Status Reason
Detail c0c2774 🚫 Skipped No files need to be tested {"apps/desktop/build/Icon-beta.icns":"File path does not match include patterns.","apps/desktop/build/Icon-nightly.icns":"File path does not match include patterns.","apps/desktop/build/Icon.icns":"File path does not match include patterns.","apps/desktop/build/icon-beta.png":"File path does not match include patterns.","apps/desktop/build/icon-dev.png":"File path does not match include patterns.","apps/desktop/build/icon-nightly.png":"File path does not match include patterns.","apps/desktop/build/icon.png":"File path does not match include patterns."}

History Assignment

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.05%. Comparing base (d8bfec0) to head (2d0d622).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9421   +/-   ##
=======================================
  Coverage   80.05%   80.05%           
=======================================
  Files         853      853           
  Lines       54471    54471           
  Branches     5888     5890    +2     
=======================================
  Hits        43605    43605           
  Misses      10866    10866           
Flag Coverage Δ
app 78.33% <ø> (ø)
database 98.31% <ø> (ø)
packages/agent-runtime 62.53% <ø> (ø)
packages/context-engine 68.73% <ø> (ø)
packages/electron-server-ipc 93.76% <ø> (ø)
packages/file-loaders 88.00% <ø> (ø)
packages/model-bank 100.00% <ø> (ø)
packages/model-runtime 77.55% <ø> (ø)
packages/prompts 92.22% <ø> (ø)
packages/python-interpreter 96.50% <ø> (ø)
packages/utils 94.75% <ø> (ø)
packages/web-crawler 97.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 70.93% <ø> (ø)
Services 61.75% <ø> (ø)
Server 64.90% <ø> (ø)
Libs 51.60% <ø> (ø)
Utils 75.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot bot added the 🐛 Bug Something isn't working | 缺陷 label Sep 25, 2025
@lobehubbot
Copy link
Member

👍 @tjx666

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

github-actions bot commented Sep 25, 2025

🚀 Desktop App Build Completed!

Version: 0.0.0-nightly.pr9421.6575
Build Time: 2025-10-08T16:39:36.979Z

📦 View All Build Artifacts

Build Artifacts

Platform File Size
macOS (Apple Silicon) LobeHub-Nightly-0.0.0-nightly.pr9421.6575-arm64.dmg 182.53 MB
macOS (Intel) LobeHub-Nightly-0.0.0-nightly.pr9421.6575-x64.dmg 185.15 MB
Windows LobeHub-Nightly-0.0.0-nightly.pr9421.6575-setup.exe 152.02 MB
Linux LobeHub-Nightly-0.0.0-nightly.pr9421.6575.AppImage 224.94 MB

Warning

Note: This is a temporary build for testing purposes only.

@tjx666 tjx666 force-pushed the tj/fix/macos26-icons branch from c0c2774 to 4a4b7b2 Compare October 7, 2025 12:54
- Add pre-generated Assets.car files for all build variants
- Configure afterPack hook to copy Assets.car during build
- Maintain backward compatibility with .icns fallback for older macOS

Reference: electron-userland/electron-builder#9254
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Oct 7, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New security issues found

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 8, 2025
@arvinxx arvinxx merged commit ca03342 into main Oct 8, 2025
60 of 67 checks passed
@arvinxx arvinxx deleted the tj/fix/macos26-icons branch October 8, 2025 15:30
@lobehubbot
Copy link
Member

❤️ Great PR @tjx666 ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

lobehubbot pushed a commit that referenced this pull request Oct 8, 2025
### [Version&nbsp;1.135.6](v1.135.5...v1.135.6)
<sup>Released on **2025-10-08**</sup>

#### 🐛 Bug Fixes

- **desktop**: Macos26 small icon.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **desktop**: Macos26 small icon, closes [#9421](#9421) ([ca03342](ca03342))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.135.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Waaade-QAQ pushed a commit to Waaade-QAQ/lobe-chat-wade that referenced this pull request Oct 10, 2025
* 🐛 fix(desktop): macos26 icon small

* Revert "🐛 fix(desktop): macos26 icon small"

This reverts commit 4a4b7b2.

* ✨ feat(desktop): support Liquid Glass icons for macOS 26

- Add pre-generated Assets.car files for all build variants
- Configure afterPack hook to copy Assets.car during build
- Maintain backward compatibility with .icns fallback for older macOS

Reference: electron-userland/electron-builder#9254

* docs: optimize comments

* fix: update deprecated macos-13 to macos-15-intel

* docs: optimize ai rules
Waaade-QAQ pushed a commit to Waaade-QAQ/lobe-chat-wade that referenced this pull request Oct 10, 2025
### [Version&nbsp;1.135.6](lobehub/lobe-chat@v1.135.5...v1.135.6)
<sup>Released on **2025-10-08**</sup>

#### 🐛 Bug Fixes

- **desktop**: Macos26 small icon.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **desktop**: Macos26 small icon, closes [lobehub#9421](lobehub#9421) ([ca03342](lobehub@ca03342))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working | 缺陷 Build Desktop 打上这个 label 后就可以触发 Desktop 构建 released size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants