-
Notifications
You must be signed in to change notification settings - Fork 14.8k
[clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check #118568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chomosuke
wants to merge
18
commits into
llvm:main
Choose a base branch
from
chomosuke:fix-leave-comma
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b43a260
fixed removeFunctionArgs don't remove comma
chomosuke 8a3f82f
Merge branch 'main' into fix-leave-comma
chomosuke 61ea649
Merge branch 'main' into fix-leave-comma
chomosuke 8082e34
Merge branch 'main' into fix-leave-comma
chomosuke 644c849
find , and remove only ,
chomosuke 2af7804
Merge branch 'main' into fix-leave-comma
chomosuke 2e80b9b
no auto when type isn't obvious and added to release note
chomosuke 4c75da3
Merge branch 'main' into fix-leave-comma
chomosuke e3d3ad0
Merge branch 'main' into fix-leave-comma
chomosuke 323fbe3
Addressed comments
chomosuke 2d49638
Merge branch 'main' into fix-leave-comma
chomosuke 2b40684
Merge remote-tracking branch 'upstream/main' into fix-leave-comma
chomosuke 1062399
addressed const comments
chomosuke bcf5de1
Merge branch 'main' into fix-leave-comma
chomosuke 84cf8d0
Merge branch 'main' into fix-leave-comma
chomosuke 9c42c9f
Merge branch 'main' into fix-leave-comma
chomosuke 19b69fc
Merge branch 'main' into fix-leave-comma
chomosuke 56d8cee
Merge branch 'main' into fix-leave-comma
chomosuke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.