Skip to content

[CIR] Adds support for __sync_lock_release #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
+109 −2
Merged

[CIR] Adds support for __sync_lock_release #1983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2132,8 +2132,19 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
case Builtin::BI__sync_lock_release_2:
case Builtin::BI__sync_lock_release_4:
case Builtin::BI__sync_lock_release_8:
case Builtin::BI__sync_lock_release_16:
llvm_unreachable("BI__sync_lock_release_1 like NYI");
case Builtin::BI__sync_lock_release_16: {
Address ptr = checkAtomicAlignment(*this, E);
QualType elTy = E->getArg(0)->getType()->getPointeeType();

auto iTy =
cir::IntType::get(&getMLIRContext(), getContext().getTypeSize(elTy),
elTy->isSignedIntegerType());
auto store = builder.createStore(
getLoc(E->getSourceRange()),
builder.getNullValue(iTy, getLoc(E->getBeginLoc())), ptr);
store.setAtomic(cir::MemOrder::Release);
return RValue::get(nullptr);
}

case Builtin::BI__sync_synchronize:
llvm_unreachable("BI__sync_synchronize NYI");
Expand Down
96 changes: 96 additions & 0 deletions clang/test/CIR/CodeGen/atomic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1367,3 +1367,99 @@ void swap(unsigned short* a, short b) {
void swap(unsigned char* a, char b) {
unsigned char c = __sync_swap(a, b);
}

// CHECK-LABEL: @_Z12lock_releasePi
// CHECK: cir.store align(4) atomic(release) {{.*}}, {{.*}} : !s32i, !cir.ptr<!s32i>

// LLVM-LABEL: @_Z12lock_releasePi
// LLVM: store atomic i32 0, ptr {{.*}} release, align 4

// OGCG-LABEL: @_Z12lock_releasePi
// OGCG: store atomic i32 0, ptr {{.*}} release, align 4
void lock_release(int* a) {
__sync_lock_release(a);
}

// CHECK-LABEL: @_Z12lock_releasePl
// CHECK: cir.store align(8) atomic(release) {{.*}}, {{.*}} : !s64i, !cir.ptr<!s64i>

// LLVM-LABEL: @_Z12lock_releasePl
// LLVM: store atomic i64 0, ptr {{.*}} release, align 8

// OGCG-LABEL: @_Z12lock_releasePl
// OGCG: store atomic i64 0, ptr {{.*}} release, align 8
void lock_release(long* a) {
__sync_lock_release(a);
}

// CHECK-LABEL: @_Z12lock_releasePs
// CHECK: cir.store align(2) atomic(release) {{.*}}, {{.*}} : !s16i, !cir.ptr<!s16i>

// LLVM-LABEL: @_Z12lock_releasePs
// LLVM: store atomic i16 0, ptr {{.*}} release, align 2

// OGCG-LABEL: @_Z12lock_releasePs
// OGCG: store atomic i16 0, ptr {{.*}} release, align 2
void lock_release(short* a) {
__sync_lock_release(a);
}

// CHECK-LABEL: @_Z12lock_releasePc
// CHECK: cir.store align(1) atomic(release) {{.*}}, {{.*}} : !s8i, !cir.ptr<!s8i>

// LLVM-LABEL: @_Z12lock_releasePc
// LLVM: store atomic i8 0, ptr {{.*}} release, align 1

// OGCG-LABEL: @_Z12lock_releasePc
// OGCG: store atomic i8 0, ptr {{.*}} release, align 1
void lock_release(char* a) {
__sync_lock_release(a);
}

// CHECK-LABEL: @_Z12lock_releasePj
// CHECK: cir.store align(4) atomic(release) {{.*}}, {{.*}} : !u32i, !cir.ptr<!u32i>

// LLVM-LABEL: @_Z12lock_releasePj
// LLVM: store atomic i32 0, ptr {{.*}} release, align 4

// OGCG-LABEL: @_Z12lock_releasePj
// OGCG: store atomic i32 0, ptr {{.*}} release, align 4
void lock_release(unsigned int* a) {
__sync_lock_release(a);
}

// CHECK-LABEL: @_Z12lock_releasePm
// CHECK: cir.store align(8) atomic(release) {{.*}}, {{.*}} : !u64i, !cir.ptr<!u64i>

// LLVM-LABEL: @_Z12lock_releasePm
// LLVM: store atomic i64 0, ptr {{.*}} release, align 8

// OGCG-LABEL: @_Z12lock_releasePm
// OGCG: store atomic i64 0, ptr {{.*}} release, align 8
void lock_release(unsigned long* a) {
__sync_lock_release(a);
}

// CHECK-LABEL: @_Z12lock_releasePt
// CHECK: cir.store align(2) atomic(release) {{.*}}, {{.*}} : !u16i, !cir.ptr<!u16i>

// LLVM-LABEL: @_Z12lock_releasePt
// LLVM: store atomic i16 0, ptr {{.*}} release, align 2

// OGCG-LABEL: @_Z12lock_releasePt
// OGCG: store atomic i16 0, ptr {{.*}} release, align 2
void lock_release(unsigned short* a) {
__sync_lock_release(a);
}

// CHECK-LABEL: @_Z12lock_releasePh
// CHECK: cir.store align(1) atomic(release) {{.*}}, {{.*}} : !u8i, !cir.ptr<!u8i>

// LLVM-LABEL: @_Z12lock_releasePh
// LLVM: store atomic i8 0, ptr {{.*}} release, align 1

// OGCG-LABEL: @_Z12lock_releasePh
// OGCG: store atomic i8 0, ptr {{.*}} release, align 1
void lock_release(unsigned char* a) {
__sync_lock_release(a);
}
Loading