Skip to content

Conversation

yankay
Copy link
Collaborator

@yankay yankay commented Aug 8, 2025

Summary

This PR fixes 2 critical bugs in the Redis index implementation and adds unit tests for both Redis and in-memory kvblock index backends.

Changes Made

🐛 Bug Fixes

  • ​​Fixed Redis pod identifier parsing​​: Modified the string split delimiter from : to @ to align with the expected PodEntry tostring format (podID@deviceTier). This change ensures accurate parsing when handling IPv6 addresses (which contain :) in PodEntry IP fields.
    But it's a break change when upgrading.
  • Fixed Redis Lookup return value: Corrected slice boundary calculation from keys[:highestHitIdx] to keys[:highestHitIdx+1] to include the last hit key

✅ Testing Improvements

  • Added basic unit tests for both Redis and in-memory index implementations
  • Added miniredis dependency for lightweight Redis testing without external dependencies
    ref: Unit Tests #72

Copy link
Member

@vMaroon vMaroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @yankay.

@vMaroon vMaroon merged commit 040f4c5 into llm-d:main Aug 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants