Skip to content

Conversation

dumb0002
Copy link
Contributor

This PR removes setting a default storage (i.e., ocs-storagecluster-cephfs) so that PVC for the vLLM pod can use a default storageClass available in any k8s cluster. Consequently, this will allow the deployment of the vLLM pod on environment independently of their default storageClass.

Copy link
Member

@vMaroon vMaroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vMaroon
Copy link
Member

vMaroon commented Jul 22, 2025

@dumb0002 thanks for fixing - can you verify your signature?

@dumb0002 dumb0002 force-pushed the remove-default-sc branch 3 times, most recently from 647be76 to d6504e9 Compare July 22, 2025 18:54
Signed-off-by: Braulio Dumba <[email protected]>
@dumb0002 dumb0002 force-pushed the remove-default-sc branch from d6504e9 to c877fe4 Compare July 22, 2025 19:05
@dumb0002
Copy link
Contributor Author

@dumb0002 thanks for fixing - can you verify your signature?

@vMaroon done, thanks!

@vMaroon vMaroon merged commit e57f9bf into llm-d:main Jul 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants